[native, lib] Move resetUserStateActionType to lib
ClosedPublic
Actions

Authored by inka on Jul 18 2023, 11:40 AM.

Details

Reviewers

michal
kamil

Commits

rCOMM8ea434915603: [native, lib] Move resetUserStateActionType to lib

Summary

As mentioned in https://linear.app/comm/issue/ENG-4377/refactor-cookie-field-in-web-redux I need to move resetUserStateActionType to lib, because the cookie filed will be in the KesyerveStore, that will be in BaseAppState, so it makes
sense it be reduced by a reducer from lib. And resetUserStateActionType influences the cookie field in redux-setup.js. Since the action will now be in lib, we can move the logic that reduces CurrentUserInfo when this action is called
to lib as well

Test Plan

ran yarn flow all. Checked that resetUserStateActionType is not reduced anywhere else.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Jul 18 2023, 11:40 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 18 2023, 11:40 AM

inka added inline comments.Jul 18 2023, 11:44 AM

native/redux/redux-setup.js
331–340 ↗	(On Diff #28782)	This had to be moved here, because now we don't want to return from this if, we need to assign `state` and let it continue to `baseReducer`. And if we do that in the `if else` above, then flow is not sure about the action type and shows errors

Harbormaster completed remote builds in B20992: Diff 28782.Jul 18 2023, 11:58 AM

inka requested review of this revision.Jul 18 2023, 11:58 AM

inka added a child revision: D8532: [lib, native,keyserver] Add KeyserverStore.Jul 18 2023, 12:31 PM

michal accepted this revision.Jul 19 2023, 3:09 AM

michal added inline comments.

lib/actions/user-actions.js
323 ↗	(On Diff #28782)	Nit: I think we prefer exporting at the end of the file instead of inline
lib/types/redux-types.js
1171 ↗	(On Diff #28782)	Any reason for adding void payload here?