Page MenuHomePhabricator

[web] Fix small thread list scrolling issue
ClosedPublic

Authored by michal on Aug 4 2023, 1:49 AM.
Tags
None
Referenced Files
F3395869: D8727.diff
Sun, Dec 1, 8:16 AM
Unknown Object (File)
Nov 1 2024, 6:31 AM
Unknown Object (File)
Nov 1 2024, 6:31 AM
Unknown Object (File)
Nov 1 2024, 6:30 AM
Unknown Object (File)
Nov 1 2024, 3:47 AM
Unknown Object (File)
Oct 10 2024, 4:41 AM
Unknown Object (File)
Oct 4 2024, 4:00 PM
Unknown Object (File)
Oct 4 2024, 4:31 AM
Subscribers

Details

Summary

Just noticed that if you put your mouse cursor on the thread list in a place where the scrollbar normally displays you won't be able to scroll because there will another top-level scrollbar (for some reason on production I can only reproduce it in cases where the threads don't fill the whole list).

This was introduced when I landed ENG-3976 because the thread list container now contains the react-window list and the scrollbars overlap each other. This is a quick fix that sets overflow: hidden on the container (we don't want to scroll it, the scrolling is handled by the inner list).

Test Plan

Try the reproduction mentioned in the summary and check if the scrolling works and the second scrollbar doesn't appear

Diff Detail

Repository
rCOMM Comm
Branch
michal/react-window-scrollbar
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

michal requested review of this revision.Aug 4 2023, 2:08 AM

Tested this on Safari and Chrome and it's working! Weird that on Firefox everything works well with overflow: auto.

This revision is now accepted and ready to land.Aug 4 2023, 2:58 AM