[lib] Memoize array that gets passed to useThreadSearchIndex
ClosedPublic
Actions

Authored by ashoat on Aug 8 2023, 6:57 AM.

Details

Reviewers

atul
tomek
ginsu

Commits

rCOMM6257ce420776: [lib] Memoize array that gets passed to useThreadSearchIndex

Summary

This addresses ENG-4605 by fixing the regression that I introduced here.

Test Plan

I was able to repro the issue in my local environment by opening the SidebarListModal on my iOS simulator. After this diff, the issue no longer reproed

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/sidebarlistmodal

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Aug 8 2023, 6:57 AM

Harbormaster completed remote builds in B21588: Diff 29617.Aug 8 2023, 7:16 AM

ashoat requested review of this revision.Aug 8 2023, 7:16 AM

tomek accepted this revision.Aug 8 2023, 7:36 AM

This revision is now accepted and ready to land.Aug 8 2023, 7:36 AM

Closed by commit rCOMM6257ce420776: [lib] Memoize array that gets passed to useThreadSearchIndex (authored by ashoat). · Explain WhyAug 8 2023, 7:51 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM6257ce420776: [lib] Memoize array that gets passed to useThreadSearchIndex.

ashoat mentioned this in D9297: [lib] Fix memoization of useSearchSidebars.Sep 26 2023, 11:04 AM

ashoat mentioned this in rCOMM101eb34481de: [lib] Fix memoization of useSearchSidebars.Sep 26 2023, 11:29 AM

ashoat mentioned this in D10253: [web] Update AddUsersList to call useUserSearchIndex.Dec 11 2023, 9:38 AM

ashoat mentioned this in D13874: [lib] Avoid creating new array on every invocation of useThreadHasPermission.Thu, Nov 7, 5:13 AM

Revision Contents
Changeset List

Path

Size

lib/

hooks/

search-threads.js

6 lines

Diff 29617

View Options

lib/hooks/search-threads.js

[lib] Memoize array that gets passed to useThreadSearchIndexClosedPublicActions