Details

Reviewers

Commits

rCOMM35bdc6df4f0c: Remove 3rd node-fetch package and use native API instead

Summary

As of the parent differential we no longer have to use 3rd party node-fetch API since its
enchanced version comes embedded within node v18. This differential removes this package from the project
and replaces its useges with native API.

Test Plan

Tried sending messages to windows app and they were received correctly. Confirmed that the keyserver obtained WNS token correctly.

Diff Detail

Repository

rCOMM Comm

Branch

marcin/eng-4527

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Jul 28 2023, 6:15 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 28 2023, 6:15 AM

Rebase to update commit message

marcin added a parent revision: D8520: Modify NIX and keyserver configuration files to allow node version >= 18.Jul 28 2023, 6:18 AM

marcin added a child revision: D8521: Enable webcrypto usage in keyserver codebase and unify aes crypto stack across web and the keyserver.

marcin added inline comments.Jul 28 2023, 6:28 AM

keyserver/src/push/utils.js
370 ↗	(On Diff #29167)	In `node-fetch` `result.headers.get('....')` is typed as `string`, while in native `node-fetch` it is typed as `null \| string`. Therefore without this `invariant` return type of `wnsPush` would be violated as it expects `wnsID` property to be always `string`.
package.json
56 ↗	(On Diff #29167)	If anyone gets confused the reason for this changed has been explained previously: https://phab.comm.dev/D8529?id=28774#inline-54808