resolves the following request access copy touchup:
Depends on D8781
Details
Details
Please see screenshots:
Default states:
Success state:
Error state:
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| landing/request-access.css | ||
|---|---|---|
| 18 | Increased width here to accommodate for the increase in the width of the text content going from "Request access" => "Subscribe for updates" | |
| landing/subscription-form.react.js | ||
| 70 | https://linear.app/comm/issue/ENG-4620#comment-f031c572 @ashoat and I talk about making the text read "Subscribe for updates" | |
| 83 | https://linear.app/comm/issue/ENG-4620#comment-fcc1b8af @ashoat and I talk about removing the feedback text | |
| landing/subscription-form.react.js | ||
|---|---|---|
| 83–85 | Why didn't you remove feedbackText / feedbackTextStyle here? | |
| landing/subscription-form.react.js | ||
|---|---|---|
| 83–85 | ahh I just missed that thanks for catching this | |
| landing/request-access.css | ||
|---|---|---|
| 18 ↗ | (On Diff #29842) | Increased width here to accommodate for the increase in the width of the text content going from "Request access" => "Subscribe for updates" |
| landing/subscription-form.react.js | ||
| 70 ↗ | (On Diff #29842) | https://linear.app/comm/issue/ENG-4620#comment-f031c572 @ashoat and I talk about making the text read "Subscribe for updates" |
| 83 ↗ | (On Diff #29842) | https://linear.app/comm/issue/ENG-4620#comment-fcc1b8af @ashoat and I talk about removing this feedback text |
| landing/subscription-form.react.js | ||
|---|---|---|
| 74 ↗ | (On Diff #29842) | Why is this still here? What is it for? |
| landing/subscription-form.react.js | ||
|---|---|---|
| 74 ↗ | (On Diff #29842) | Can you rename the variable and remove the code for determining the color? Imagine this was built from scratch just to support the error case… what would it look like? |
| landing/request-access.css | ||
|---|---|---|
| 18 ↗ | (On Diff #29845) | Increased width here to accommodate for the increase in the width of the text content going from "Request access" => "Subscribe for updates" |
| landing/subscription-form.react.js | ||
| 90–97 ↗ | (On Diff #29845) | I thought it was cleaner to create this additional if block instead of trying to fit this in to the if block above |