Page MenuHomePhabricator
Differential D8784

[landing] address signal comparison copy touch ups
ClosedPublic
Actions

Authored by ginsu on Aug 10 2023, 3:21 PM.
Tags
None
Referenced Files
F3529215: D8784.diff
Tue, Dec 24, 5:02 PM
Unknown Object (File)
Fri, Dec 20, 5:56 PM
Unknown Object (File)
Nov 23 2024, 1:59 PM
Unknown Object (File)
Nov 23 2024, 12:59 PM
Unknown Object (File)
Nov 21 2024, 8:18 AM
Unknown Object (File)
Nov 21 2024, 8:18 AM
Unknown Object (File)
Nov 21 2024, 8:18 AM
Unknown Object (File)
Nov 21 2024, 8:18 AM
View All 100 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
ashoat
Commits
rCOMMa24bc33f52f1: [landing] address signal comparison copy touch ups
Summary

resolves the following signal comparison copy:

https://linear.app/comm/issue/ENG-4622/signal-comparison

Depends on D8783

Test Plan

Please see the screenshot:

Screenshot 2023-08-10 at 6.22.45 PM.png (2×3 px, 889 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Aug 10 2023, 3:21 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 10 2023, 3:21 PM
ginsu edited the summary of this revision. (Show Details)Aug 10 2023, 3:23 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, kamil.
ginsu added a parent revision: D8783: [landing] address keyserver copy on the main page touchups.
ginsu attached a referenced file: F684537: Screenshot 2023-08-10 at 6.22.45 PM.png. (Show Details)
ginsu added a child revision: D8785: [landing] address keybase comparison touch ups.Aug 10 2023, 3:38 PM
Harbormaster completed remote builds in B21702: Diff 29827.Aug 10 2023, 3:39 PM
ginsu requested review of this revision.Aug 10 2023, 3:39 PM
ashoat accepted this revision.Aug 11 2023, 5:30 AM
This revision is now accepted and ready to land.Aug 11 2023, 5:30 AM
ginsu updated this revision to Diff 29887.Aug 15 2023, 7:26 AM

rebase before landing

This revision was landed with ongoing or failed builds.Aug 15 2023, 7:30 AM
Closed by commit rCOMMa24bc33f52f1: [landing] address signal comparison copy touch ups (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMa24bc33f52f1: [landing] address signal comparison copy touch ups.
Harbormaster completed remote builds in B21748: Diff 29887.Aug 15 2023, 7:44 AM

Revision Contents
Changeset List

PathSize
landing/
2 lines

Diff 29827

View Options

landing/competitor-data.js

Loading...