Page MenuHomePhabricator
Differential D8793

[landing] address slack comparison touch ups
ClosedPublic
Actions

Authored by ginsu on Aug 10 2023, 4:13 PM.
Tags
None
Referenced Files
F3770828: D8793.id29891.diff
Sun, Jan 12, 10:12 AM
F3770810: D8793.id29900.diff
Sun, Jan 12, 10:00 AM
Unknown Object (File)
Mon, Dec 30, 5:12 PM
Unknown Object (File)
Mon, Dec 30, 5:12 PM
Unknown Object (File)
Mon, Dec 30, 5:12 PM
Unknown Object (File)
Mon, Dec 30, 5:01 PM
Unknown Object (File)
Mon, Dec 30, 4:17 PM
Unknown Object (File)
Sat, Dec 28, 4:10 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
ashoat
Commits
rCOMMc824654415fd: [landing] address slack comparison touch ups
Summary

resolves the following slack comparison copy touch up:

https://linear.app/comm/issue/ENG-4627/slack-comparison

Depends on D8792

Test Plan

Please screenshot:

Screenshot 2023-08-10 at 7.14.45 PM.png (2×3 px, 707 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Aug 10 2023, 4:13 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 10 2023, 4:13 PM
ginsu edited the test plan for this revision. (Show Details)Aug 10 2023, 4:16 PM
ginsu added reviewers: atul, kamil.
ginsu attached a referenced file: F684807: Screenshot 2023-08-10 at 7.14.45 PM.png. (Show Details)
ginsu edited the summary of this revision. (Show Details)
ginsu edited the test plan for this revision. (Show Details)
ginsu added a parent revision: D8792: [landing] address discord comparison touch ups.
ginsu edited the test plan for this revision. (Show Details)Aug 10 2023, 4:18 PM
ginsu attached a referenced file: F684839: Screenshot 2023-08-10 at 7.14.45 PM.png. (Show Details)
ginsu added a child revision: D8794: [landing] address matrix comparison touch ups.
Harbormaster completed remote builds in B21711: Diff 29836.Aug 10 2023, 4:30 PM
ginsu requested review of this revision.Aug 10 2023, 4:30 PM
ashoat accepted this revision.Aug 11 2023, 5:33 AM
This revision is now accepted and ready to land.Aug 11 2023, 5:33 AM
ginsu updated this revision to Diff 29891.Aug 15 2023, 7:27 AM

rebase before landing

This revision was landed with ongoing or failed builds.Aug 15 2023, 7:30 AM
Closed by commit rCOMMc824654415fd: [landing] address slack comparison touch ups (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMc824654415fd: [landing] address slack comparison touch ups.
Harbormaster completed remote builds in B21752: Diff 29891.Aug 15 2023, 7:50 AM

Revision Contents
Changeset List

PathSize
landing/
4 lines

Diff 29836

View Options

landing/competitor-data.js

Loading...