Page MenuHomePhabricator

[native] fix forcing the incorrect height for text messages
ClosedPublic

Authored by ginsu on Aug 12 2023, 1:07 PM.
Tags
None
Referenced Files
F3299887: D8798.id29847.diff
Sun, Nov 17, 4:21 PM
F3299680: D8798.diff
Sun, Nov 17, 2:41 PM
Unknown Object (File)
Tue, Oct 22, 6:37 AM
Unknown Object (File)
Tue, Oct 22, 6:37 AM
Unknown Object (File)
Tue, Oct 22, 6:36 AM
Unknown Object (File)
Tue, Oct 22, 6:35 AM
Unknown Object (File)
Tue, Oct 22, 5:03 AM
Unknown Object (File)
Oct 18 2024, 3:57 PM
Subscribers

Details

Summary

This diff is part 2/3 to fix forcing the incorrect height for messages with inline engagement in prod.

This linear comment explains this issue and what I did to address this

Since item.contentHeight is now the height of the inner text message AND the height of the inline engagement we are now forcing the wrong height for the inner text message component. An idea I want to explore to address this is to force the height higher up in the component tree (somewhere like ComposedMessage) where both the "inner message" and the inline engagement is rendered so that when we force the height withitem.contentHeight, it is correct

Depends on D8797

Test Plan

Please see demo video where I force and unforce the correct height of the text message and it did not change visually (outside of the green background) and I did not get any error logs talking about incorrect height measurements, I also purposely force an incorrect height (which resulted in some logs about incorrect height measurements.

Also please note for the video, I set a green background so that it is easier to visually see what is happening, but these are only for the demo videos

With the correct height measurement:

With the incorrect height measurement:

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu requested review of this revision.Aug 12 2023, 1:26 PM
This revision is now accepted and ready to land.Aug 15 2023, 6:31 AM
This revision was landed with ongoing or failed builds.Aug 15 2023, 9:44 AM
This revision was automatically updated to reflect the committed changes.