Page MenuHomePhabricator
Differential D8783

[landing] address keyserver copy on the main page touchups
ClosedPublic
Actions

Authored by ginsu on Aug 10 2023, 3:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 31, 2:49 PM
Unknown Object (File)
Mon, Dec 30, 5:12 PM
Unknown Object (File)
Mon, Dec 30, 5:12 PM
Unknown Object (File)
Mon, Dec 30, 5:12 PM
Unknown Object (File)
Mon, Dec 30, 5:01 PM
Unknown Object (File)
Mon, Dec 30, 4:17 PM
Unknown Object (File)
Wed, Dec 25, 6:12 AM
Unknown Object (File)
Wed, Dec 25, 5:53 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
ashoat
Commits
rCOMMa2437ab455ee: [landing] address keyserver copy on the main page touchups
Summary

resolves the following keyserver copy on the main page touchup:

https://linear.app/comm/issue/ENG-4623/keyserver-copy-on-the-main-page

Depends on D8782

Test Plan

Please see the screenshot:

Screenshot 2023-08-10 at 6.16.39 PM.png (2×3 px, 871 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Aug 10 2023, 3:16 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 10 2023, 3:16 PM
ginsu edited the summary of this revision. (Show Details)Aug 10 2023, 3:18 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, kamil.
ginsu added a parent revision: D8782: [landing] change request access back to subscribe for updates.
ginsu attached a referenced file: F684507: Screenshot 2023-08-10 at 6.16.39 PM.png. (Show Details)
ginsu added a child revision: D8784: [landing] address signal comparison copy touch ups.Aug 10 2023, 3:23 PM
Harbormaster completed remote builds in B21701: Diff 29826.Aug 10 2023, 3:34 PM
ginsu requested review of this revision.Aug 10 2023, 3:34 PM
ashoat accepted this revision.Aug 11 2023, 5:30 AM
This revision is now accepted and ready to land.Aug 11 2023, 5:30 AM
ginsu updated this revision to Diff 29886.Aug 15 2023, 7:25 AM

rebase before landing

This revision was landed with ongoing or failed builds.Aug 15 2023, 7:30 AM
Closed by commit rCOMMa2437ab455ee: [landing] address keyserver copy on the main page touchups (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMa2437ab455ee: [landing] address keyserver copy on the main page touchups.
Harbormaster completed remote builds in B21747: Diff 29886.Aug 15 2023, 7:44 AM

Revision Contents
Changeset List

PathSize
landing/
4 lines

Diff 29895

View Options

landing/asset-meta-data.js

Loading...