Page MenuHomePhabricator
Differential D8820

[Keyserver/rust] Used shared identity client
ClosedPublic
Actions

Authored by varun on Aug 15 2023, 10:23 AM.
Tags
None
Referenced Files
F5353533: D8820.diff
Wed, Apr 9, 10:44 AM
Unknown Object (File)
Wed, Apr 2, 8:18 AM
Unknown Object (File)
Tue, Apr 1, 9:12 AM
Unknown Object (File)
Fri, Mar 28, 5:39 PM
Unknown Object (File)
Sat, Mar 15, 8:12 AM
Unknown Object (File)
Mar 10 2025, 3:59 AM
Unknown Object (File)
Mar 10 2025, 3:58 AM
Unknown Object (File)
Mar 10 2025, 3:58 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
• jon
Commits
rCOMM269eddc91b6b: [Keyserver/rust] Used shared identity client
Summary

Apply shared identity client back to rust-node-addon to
verify that it works. Also cleans up the code quite a bit.

Related to: https://linear.app/comm/issue/ENG-4640

Depends on D8804

Test Plan
  • Run identity service and localstack
  • Verify that keyserver can login to identity service upon start

Diff Detail

Repository
rCOMM Comm
Branch
jonringer/identity-client
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Aug 15 2023, 10:23 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 15 2023, 10:23 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Aug 15 2023, 10:33 AM
Harbormaster failed remote builds in B21764: Diff 29917!
• jon updated this revision to Diff 29929.Aug 15 2023, 8:16 PM

Fix docker build

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 15 2023, 8:27 PM
Harbormaster failed remote builds in B21775: Diff 29929!
• jon updated this revision to Diff 29964.Aug 16 2023, 8:04 AM

Rebase on master

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 16 2023, 8:14 AM
Harbormaster failed remote builds in B21800: Diff 29964!
• jon updated this revision to Diff 29978.Aug 16 2023, 12:37 PM

Fix docker build, not sure why previous change wasn't applied

Harbormaster completed remote builds in B21811: Diff 29978.Aug 16 2023, 12:59 PM
• jon requested review of this revision.Aug 16 2023, 12:59 PM
ashoat added inline comments.Aug 16 2023, 1:06 PM
keyserver/Dockerfile
136 ↗(On Diff #29978)

Is this really necessary? I'm afraid it will hurt performance of the Docker build here. Do we really need everything in shared/, or can we copy over what we need piecemeal?

varun accepted this revision.Aug 16 2023, 1:54 PM
This revision is now accepted and ready to land.Aug 16 2023, 1:54 PM
ashoat added inline comments.Aug 16 2023, 2:10 PM
keyserver/Dockerfile
136 ↗(On Diff #29978)

Also please try to keep things consistent in this file. All other COPY commands omit the trailing slash on the first parameter

• jon updated this revision to Diff 29990.Aug 17 2023, 12:08 AM
• jon marked 2 inline comments as done.

Address feedback on docker COPY command

Harbormaster completed remote builds in B21818: Diff 29990.Aug 17 2023, 12:27 AM
• jon added inline comments.Aug 17 2023, 6:56 AM
keyserver/Dockerfile
136 ↗(On Diff #29978)

We need all but cmake and tunnelbroker_messages, and the size of the folders is pretty small on a clean checkout:

$ du -hd0 ./*
4.0K	./cmake
72K	./comm-opaque2
68K	./grpc_clients
28K	./protos
28K	./tunnelbroker_messages

I just added another COPY command to keep the preference toward copying as little as needed.

136 ↗(On Diff #29978)

TIL this is to avoid issues with symlinks: https://stackoverflow.com/questions/18158248/should-i-put-trailing-slash-after-source-and-destination-when-copy-folders

ashoat added a comment.Sep 11 2023, 8:30 AM

I assume this work is necessary for the keyserver to be able to connect to the identity service. @varun, is that right? If so, I think you'll need to commandeer it.

varun commandeered this revision.Sep 11 2023, 8:33 AM
varun edited reviewers, added: • jon; removed: varun.
This revision now requires review to proceed.Sep 11 2023, 8:33 AM
bartek accepted this revision.Sep 12 2023, 12:14 AM
This revision is now accepted and ready to land.Sep 12 2023, 12:14 AM
Closed by commit rCOMM269eddc91b6b: [Keyserver/rust] Used shared identity client (authored by • jon, committed by varun). · Explain WhySep 12 2023, 12:45 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM269eddc91b6b: [Keyserver/rust] Used shared identity client.
varun mentioned this in D9473: [keyserver] change function names for getting clients to be more intuitive.Oct 12 2023, 11:57 AM
varun mentioned this in rCOMMae8f251a5b77: [keyserver] change function names for getting clients to be more intuitive.Oct 18 2023, 8:00 PM

Revision Contents
Changeset List

PathSize
keyserver/
addons/
rust-node-addon/
5 lines
10 lines
src/
identity_client/
3 lines
7 lines
77 lines
14 lines
3 lines
3 lines

Diff 29929

View Options

keyserver/addons/rust-node-addon/Cargo.lock

Show All 22 Lines
import { values } from 'lib/utils/objects.js'; import { values } from 'lib/utils/objects.js';
import { OverlayContext } from './overlay-context.js'; import { OverlayContext } from './overlay-context.js';
import OverlayRouter from './overlay-router.js'; import OverlayRouter from './overlay-router.js';
import type { OverlayRouterExtraNavigationHelpers } from './overlay-router.js'; import type { OverlayRouterExtraNavigationHelpers } from './overlay-router.js';
import { scrollBlockingModals, TabNavigatorRouteName } from './route-names.js'; import { scrollBlockingModals, TabNavigatorRouteName } from './route-names.js';
import { isMessageTooltipKey } from '../chat/utils.js'; import { isMessageTooltipKey } from '../chat/utils.js';
import { InputStateContext } from '../input/input-state.js';
export type OverlayNavigationHelpers<ParamList: ParamListBase = ParamListBase> = export type OverlayNavigationHelpers<ParamList: ParamListBase = ParamListBase> =
{ {
...$Exact<StackNavigationHelpers<ParamList, {}>>, ...$Exact<StackNavigationHelpers<ParamList, {}>>,
...OverlayRouterExtraNavigationHelpers, ...OverlayRouterExtraNavigationHelpers,
... ...
}; };
▲ Show 20 Lines • Show All 111 Lines • ▼ Show 20 Lines const getScrollBlockingModalStatus = data => {
if (!scene.context.isDismissing) { if (!scene.context.isDismissing) {
status = 'open'; status = 'open';
break; break;
} }
status = 'closing'; status = 'closing';
} }
return status; return status;
}; };
const [scrollBlockingModalStatus, setScrollBlockingModalStatus] = const [rawScrollBlockingModalStatus, setScrollBlockingModalStatus] =
React.useState(() => getScrollBlockingModalStatus(scenes)); React.useState(() => getScrollBlockingModalStatus(scenes));
const inputState = React.useContext(InputStateContext);
const scrollBlockingModalStatus = React.useMemo(() => {
if (inputState?.editState.editedMessage !== null) {
return 'closed';
}
return rawScrollBlockingModalStatus;
}, [inputState?.editState, rawScrollBlockingModalStatus]);
const sceneDataForNewScene = scene => ({ const sceneDataForNewScene = scene => ({
...scene, ...scene,
context: { context: {
...scene.context, ...scene.context,
visibleOverlays, visibleOverlays,
scrollBlockingModalStatus, scrollBlockingModalStatus,
setScrollBlockingModalStatus, setScrollBlockingModalStatus,
}, },
▲ Show 20 Lines • Show All 340 Lines • Show Last 20 Lines
View Options

keyserver/addons/rust-node-addon/Cargo.toml

Show All 22 Lines
import { values } from 'lib/utils/objects.js'; import { values } from 'lib/utils/objects.js';
import { OverlayContext } from './overlay-context.js'; import { OverlayContext } from './overlay-context.js';
import OverlayRouter from './overlay-router.js'; import OverlayRouter from './overlay-router.js';
import type { OverlayRouterExtraNavigationHelpers } from './overlay-router.js'; import type { OverlayRouterExtraNavigationHelpers } from './overlay-router.js';
import { scrollBlockingModals, TabNavigatorRouteName } from './route-names.js'; import { scrollBlockingModals, TabNavigatorRouteName } from './route-names.js';
import { isMessageTooltipKey } from '../chat/utils.js'; import { isMessageTooltipKey } from '../chat/utils.js';
import { InputStateContext } from '../input/input-state.js';
export type OverlayNavigationHelpers<ParamList: ParamListBase = ParamListBase> = export type OverlayNavigationHelpers<ParamList: ParamListBase = ParamListBase> =
{ {
...$Exact<StackNavigationHelpers<ParamList, {}>>, ...$Exact<StackNavigationHelpers<ParamList, {}>>,
...OverlayRouterExtraNavigationHelpers, ...OverlayRouterExtraNavigationHelpers,
... ...
}; };
▲ Show 20 Lines • Show All 111 Lines • ▼ Show 20 Lines const getScrollBlockingModalStatus = data => {
if (!scene.context.isDismissing) { if (!scene.context.isDismissing) {
status = 'open'; status = 'open';
break; break;
} }
status = 'closing'; status = 'closing';
} }
return status; return status;
}; };
const [scrollBlockingModalStatus, setScrollBlockingModalStatus] = const [rawScrollBlockingModalStatus, setScrollBlockingModalStatus] =
React.useState(() => getScrollBlockingModalStatus(scenes)); React.useState(() => getScrollBlockingModalStatus(scenes));
const inputState = React.useContext(InputStateContext);
const scrollBlockingModalStatus = React.useMemo(() => {
if (inputState?.editState.editedMessage !== null) {
return 'closed';
}
return rawScrollBlockingModalStatus;
}, [inputState?.editState, rawScrollBlockingModalStatus]);
const sceneDataForNewScene = scene => ({ const sceneDataForNewScene = scene => ({
...scene, ...scene,
context: { context: {
...scene.context, ...scene.context,
visibleOverlays, visibleOverlays,
scrollBlockingModalStatus, scrollBlockingModalStatus,
setScrollBlockingModalStatus, setScrollBlockingModalStatus,
}, },
▲ Show 20 Lines • Show All 340 Lines • Show Last 20 Lines
View Options

keyserver/addons/rust-node-addon/build.rs

Show All 22 Lines
import { values } from 'lib/utils/objects.js'; import { values } from 'lib/utils/objects.js';
import { OverlayContext } from './overlay-context.js'; import { OverlayContext } from './overlay-context.js';
import OverlayRouter from './overlay-router.js'; import OverlayRouter from './overlay-router.js';
import type { OverlayRouterExtraNavigationHelpers } from './overlay-router.js'; import type { OverlayRouterExtraNavigationHelpers } from './overlay-router.js';
import { scrollBlockingModals, TabNavigatorRouteName } from './route-names.js'; import { scrollBlockingModals, TabNavigatorRouteName } from './route-names.js';
import { isMessageTooltipKey } from '../chat/utils.js'; import { isMessageTooltipKey } from '../chat/utils.js';
import { InputStateContext } from '../input/input-state.js';
export type OverlayNavigationHelpers<ParamList: ParamListBase = ParamListBase> = export type OverlayNavigationHelpers<ParamList: ParamListBase = ParamListBase> =
{ {
...$Exact<StackNavigationHelpers<ParamList, {}>>, ...$Exact<StackNavigationHelpers<ParamList, {}>>,
...OverlayRouterExtraNavigationHelpers, ...OverlayRouterExtraNavigationHelpers,
... ...
}; };
▲ Show 20 Lines • Show All 111 Lines • ▼ Show 20 Lines const getScrollBlockingModalStatus = data => {
if (!scene.context.isDismissing) { if (!scene.context.isDismissing) {
status = 'open'; status = 'open';
break; break;
} }
status = 'closing'; status = 'closing';
} }
return status; return status;
}; };
const [scrollBlockingModalStatus, setScrollBlockingModalStatus] = const [rawScrollBlockingModalStatus, setScrollBlockingModalStatus] =
React.useState(() => getScrollBlockingModalStatus(scenes)); React.useState(() => getScrollBlockingModalStatus(scenes));
const inputState = React.useContext(InputStateContext);
const scrollBlockingModalStatus = React.useMemo(() => {
if (inputState?.editState.editedMessage !== null) {
return 'closed';
}
return rawScrollBlockingModalStatus;
}, [inputState?.editState, rawScrollBlockingModalStatus]);
const sceneDataForNewScene = scene => ({ const sceneDataForNewScene = scene => ({
...scene, ...scene,
context: { context: {
...scene.context, ...scene.context,
visibleOverlays, visibleOverlays,
scrollBlockingModalStatus, scrollBlockingModalStatus,
setScrollBlockingModalStatus, setScrollBlockingModalStatus,
}, },
▲ Show 20 Lines • Show All 340 Lines • Show Last 20 Lines
View Options

keyserver/addons/rust-node-addon/src/identity_client/add_reserved_usernames.rs

Show All 22 Lines
import { values } from 'lib/utils/objects.js'; import { values } from 'lib/utils/objects.js';
import { OverlayContext } from './overlay-context.js'; import { OverlayContext } from './overlay-context.js';
import OverlayRouter from './overlay-router.js'; import OverlayRouter from './overlay-router.js';
import type { OverlayRouterExtraNavigationHelpers } from './overlay-router.js'; import type { OverlayRouterExtraNavigationHelpers } from './overlay-router.js';
import { scrollBlockingModals, TabNavigatorRouteName } from './route-names.js'; import { scrollBlockingModals, TabNavigatorRouteName } from './route-names.js';
import { isMessageTooltipKey } from '../chat/utils.js'; import { isMessageTooltipKey } from '../chat/utils.js';
import { InputStateContext } from '../input/input-state.js';
export type OverlayNavigationHelpers<ParamList: ParamListBase = ParamListBase> = export type OverlayNavigationHelpers<ParamList: ParamListBase = ParamListBase> =
{ {
...$Exact<StackNavigationHelpers<ParamList, {}>>, ...$Exact<StackNavigationHelpers<ParamList, {}>>,
...OverlayRouterExtraNavigationHelpers, ...OverlayRouterExtraNavigationHelpers,
... ...
}; };
▲ Show 20 Lines • Show All 111 Lines • ▼ Show 20 Lines const getScrollBlockingModalStatus = data => {
if (!scene.context.isDismissing) { if (!scene.context.isDismissing) {
status = 'open'; status = 'open';
break; break;
} }
status = 'closing'; status = 'closing';
} }
return status; return status;
}; };
const [scrollBlockingModalStatus, setScrollBlockingModalStatus] = const [rawScrollBlockingModalStatus, setScrollBlockingModalStatus] =
React.useState(() => getScrollBlockingModalStatus(scenes)); React.useState(() => getScrollBlockingModalStatus(scenes));
const inputState = React.useContext(InputStateContext);
const scrollBlockingModalStatus = React.useMemo(() => {
if (inputState?.editState.editedMessage !== null) {
return 'closed';
}
return rawScrollBlockingModalStatus;
}, [inputState?.editState, rawScrollBlockingModalStatus]);
const sceneDataForNewScene = scene => ({ const sceneDataForNewScene = scene => ({
...scene, ...scene,
context: { context: {
...scene.context, ...scene.context,
visibleOverlays, visibleOverlays,
scrollBlockingModalStatus, scrollBlockingModalStatus,
setScrollBlockingModalStatus, setScrollBlockingModalStatus,
}, },
▲ Show 20 Lines • Show All 340 Lines • Show Last 20 Lines
View Options

keyserver/addons/rust-node-addon/src/identity_client/auth_client.rs

Loading...
View Options

keyserver/addons/rust-node-addon/src/identity_client/login.rs

Loading...
View Options

keyserver/addons/rust-node-addon/src/identity_client/mod.rs

Loading...
View Options

keyserver/addons/rust-node-addon/src/identity_client/prekey.rs

Loading...
View Options

keyserver/addons/rust-node-addon/src/identity_client/register_user.rs

Loading...
View Options

keyserver/addons/rust-node-addon/src/identity_client/remove_reserved_usernames.rs

Loading...