Page MenuHomePhabricator

[Shared] Create shared grpc_client library
ClosedPublic

Authored by jon on Aug 14 2023, 7:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 3:59 PM
Unknown Object (File)
Sun, Nov 10, 3:59 PM
Unknown Object (File)
Sun, Nov 10, 3:59 PM
Unknown Object (File)
Sun, Nov 10, 3:58 PM
Unknown Object (File)
Tue, Nov 5, 2:12 AM
Unknown Object (File)
Fri, Oct 25, 5:44 PM
Unknown Object (File)
Thu, Oct 24, 4:14 PM
Unknown Object (File)
Thu, Oct 24, 4:13 PM
Subscribers

Details

Summary

Every service and native device will need to talk to either identity
service or tunnelbroker. This begins the trend with making identity service
and related protos available as a shared library.

https://linear.app/comm/issue/ENG-4640

Test Plan
cargo build

This diff will be integrated in a later diff

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

just one nit

shared/grpc_clients/src/identity/authenticated.rs
18 ↗(On Diff #29856)

ToMetadataValue?

This revision is now accepted and ready to land.Aug 16 2023, 12:31 AM
jon marked an inline comment as done.

Address feedback

shared/grpc_clients/src/identity/authenticated.rs
18 ↗(On Diff #29856)

Probably do both then, e.g. ToMetadataValueAscii. There's some other methods which return different inner types.