Page MenuHomePhabricator
Differential D8804

[Shared] Create shared grpc_client library
ClosedPublic
Actions

Authored by • jon on Aug 14 2023, 7:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 14, 2:11 PM
Unknown Object (File)
Sun, Nov 10, 3:59 PM
Unknown Object (File)
Sun, Nov 10, 3:59 PM
Unknown Object (File)
Sun, Nov 10, 3:59 PM
Unknown Object (File)
Sun, Nov 10, 3:58 PM
Unknown Object (File)
Tue, Nov 5, 2:12 AM
Unknown Object (File)
Fri, Oct 25, 5:44 PM
Unknown Object (File)
Thu, Oct 24, 4:14 PM
View All 97 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
varun
michal
Commits
rCOMMd89982af1fce: [Shared] Create shared grpc_client library
Summary

Every service and native device will need to talk to either identity
service or tunnelbroker. This begins the trend with making identity service
and related protos available as a shared library.

https://linear.app/comm/issue/ENG-4640

Test Plan
cargo build

This diff will be integrated in a later diff

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Aug 14 2023, 7:00 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 14 2023, 7:00 AM
Harbormaster completed remote builds in B21728: Diff 29856.Aug 14 2023, 7:18 AM
• jon requested review of this revision.Aug 14 2023, 7:18 AM
• jon mentioned this in D8501: [identity] log out user RPC.Aug 15 2023, 9:42 AM
• jon added a child revision: D8820: [Keyserver/rust] Used shared identity client.Aug 15 2023, 10:23 AM
bartek added a reviewer: michal.Aug 16 2023, 12:04 AM
varun accepted this revision.Aug 16 2023, 12:31 AM

just one nit

shared/grpc_clients/src/identity/authenticated.rs
18 ↗(On Diff #29856)

ToMetadataValue?

This revision is now accepted and ready to land.Aug 16 2023, 12:31 AM
• jon updated this revision to Diff 29963.Aug 16 2023, 8:01 AM
• jon marked an inline comment as done.

Address feedback

Harbormaster completed remote builds in B21799: Diff 29963.Aug 16 2023, 8:19 AM
• jon added inline comments.Aug 16 2023, 11:58 PM
shared/grpc_clients/src/identity/authenticated.rs
18 ↗(On Diff #29856)

Probably do both then, e.g. ToMetadataValueAscii. There's some other methods which return different inner types.

Closed by commit rCOMMd89982af1fce: [Shared] Create shared grpc_client library (authored by • jon). · Explain WhyAug 17 2023, 12:01 AM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMMd89982af1fce: [Shared] Create shared grpc_client library.

Revision Contents
Changeset List

PathSize
shared/
grpc_clients/
1 line
14 lines
12 lines
src/
11 lines
identity/
60 lines
40 lines
11 lines
21 lines

Diff 29963

View Options

shared/grpc_clients/.gitignore

Loading...
View Options

shared/grpc_clients/Cargo.lock

Loading...
View Options

shared/grpc_clients/Cargo.toml

Loading...
View Options

shared/grpc_clients/build.rs

Loading...
View Options

shared/grpc_clients/src/error.rs

Loading...
View Options

shared/grpc_clients/src/identity/authenticated.rs

Loading...
View Options

shared/grpc_clients/src/identity/mod.rs

Loading...
View Options

shared/grpc_clients/src/identity/unauthenticated.rs

Loading...
View Options

shared/grpc_clients/src/lib.rs

Loading...