Page MenuHomePhabricator

[blob-service] Standardize localstack config
ClosedPublic

Authored by bartek on Aug 16 2023, 8:12 AM.
Tags
None
Referenced Files
F3346920: D8835.diff
Fri, Nov 22, 10:17 AM
Unknown Object (File)
Sun, Oct 27, 4:35 PM
Unknown Object (File)
Fri, Oct 25, 1:12 AM
Unknown Object (File)
Sep 27 2024, 10:56 PM
Unknown Object (File)
Sep 27 2024, 10:56 PM
Unknown Object (File)
Sep 27 2024, 10:56 PM
Unknown Object (File)
Sep 27 2024, 10:56 PM
Unknown Object (File)
Sep 27 2024, 10:50 PM
Subscribers

Details

Summary

We should have one standard way of configuring localstack endpoint for all services. This diff standardizes the localstack config for blob-service.
I consider Tunnelbroker as state-of-the-art solution for localstack endpoint configuration.

TL;DR

cargo run -- --sandbox --localstack-url "http://localhost:4566"

-->

cargo run

The LOCALSTACK_ENDPOINT env variable is automatically provided by Nix so no need to specify --localstack-endpoint explicitly.

Test Plan

Ran the above command and it worked. Blob service integration tests are working.

Diff Detail

Repository
rCOMM Comm
Branch
barthap/blob-config
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

This revision is now accepted and ready to land.Aug 16 2023, 8:50 AM
services/blob/src/s3.rs
110

Possibly make a helper function for checking this?

services/blob/src/s3.rs
110

I don't think that's really useful just for two places

services/blob/src/config.rs
7–8

Can these two constants be cleaned up?

services/blob/src/config.rs
7–8

lol their removal didn't commit, good catch, I was about to land this