Paths

Table of Contentst

Differential D9138

[feature-flags] Standardize localstack and http config
ClosedPublic
Actions

Authored by bartek on Sep 12 2023, 12:05 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, May 2, 3:05 PM

	Unknown Object (File)
	Fri, Apr 26, 3:30 AM

	Unknown Object (File)
	Tue, Apr 16, 5:58 PM

	Unknown Object (File)
	Tue, Apr 16, 12:45 AM

	Unknown Object (File)
	Mon, Apr 15, 9:18 PM

	Unknown Object (File)
	Mon, Apr 15, 4:04 PM

	Unknown Object (File)
	Sat, Apr 13, 3:58 PM

	Unknown Object (File)
	Apr 13 2024, 4:50 AM

View All 47 Files

Subscribers

Details

Reviewers

michal
tomek
varun
• jon

Commits

rCOMMaf6356fc54c3: [feature-flags] Standardize localstack and http config

Summary

Replaced old --sandbox flag with --localstack-endpoint that we use in other services. More info in D8835
Also renamed --port to --http-port to match other services
Changed default port to 50055, see https://linear.app/comm/issue/ENG-3288/dont-bind-services-to-default-grpc-port

Test Plan

cargo run - should start with default localstack endpoint (LOCALSTACK_ENDPOINT env is set by Nix). Default HTTP port is 50055.
The --http-port and --localstack-endpoint arguments do override the defaults.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Sep 12 2023, 12:05 AM

bartek held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptSep 12 2023, 12:05 AM

Herald added a subscriber: ashoat. · View Herald Transcript

bartek added a child revision: D9139: [feature-flags] Use default HTTP port for deployments.Sep 12 2023, 12:13 AM

Fix --http-port

bartek published this revision for review.Sep 12 2023, 12:22 AM

bartek added inline comments.

services/feature-flags/Dockerfile
35–36 ↗	(On Diff #30950)	This gets addressed in the next diff (D9139) because it requires a new deployment

Harbormaster completed remote builds in B22511: Diff 30948.Sep 12 2023, 12:24 AM

michal accepted this revision.Sep 12 2023, 12:27 AM

This revision is now accepted and ready to land.Sep 12 2023, 12:27 AM

Harbormaster completed remote builds in B22513: Diff 30950.Sep 12 2023, 12:39 AM

Closed by commit rCOMMaf6356fc54c3: [feature-flags] Standardize localstack and http config (authored by bartek). · Explain WhySep 12 2023, 10:59 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMaf6356fc54c3: [feature-flags] Standardize localstack and http config.

Revision Contents
Changeset List

Path

Size

services/

feature-flags/

3 lines

src/

31 lines

4 lines

6 lines

Diff 31022

services/feature-flags/Dockerfile

Loading...

services/feature-flags/src/config.rs

Loading...

services/feature-flags/src/constants.rs

Loading...

services/feature-flags/src/service.rs

Loading...