Page MenuHomePhabricator

[feature-flags] Standardize localstack and http config
ClosedPublic

Authored by bartek on Sep 12 2023, 12:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 7:41 PM
Unknown Object (File)
Wed, Nov 13, 7:06 PM
Unknown Object (File)
Tue, Nov 12, 11:51 AM
Unknown Object (File)
Sun, Oct 27, 4:34 PM
Unknown Object (File)
Oct 1 2024, 2:54 AM
Unknown Object (File)
Sep 27 2024, 10:57 PM
Unknown Object (File)
Sep 27 2024, 10:57 PM
Unknown Object (File)
Sep 27 2024, 10:57 PM
Subscribers

Details

Summary
Test Plan

cargo run - should start with default localstack endpoint (LOCALSTACK_ENDPOINT env is set by Nix). Default HTTP port is 50055.
The --http-port and --localstack-endpoint arguments do override the defaults.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Sep 12 2023, 12:22 AM
bartek added inline comments.
services/feature-flags/Dockerfile
35–36 ↗(On Diff #30950)

This gets addressed in the next diff (D9139)
because it requires a new deployment

This revision is now accepted and ready to land.Sep 12 2023, 12:27 AM