Page MenuHomePhabricator
Differential D9138

[feature-flags] Standardize localstack and http config
ClosedPublic
Actions

Authored by bartek on Sep 12 2023, 12:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 25, 4:47 PM
Unknown Object (File)
Sun, Mar 23, 8:46 AM
Unknown Object (File)
Sun, Mar 23, 8:46 AM
Unknown Object (File)
Sun, Mar 23, 8:46 AM
Unknown Object (File)
Sun, Mar 23, 8:46 AM
Unknown Object (File)
Sun, Mar 23, 3:32 AM
Unknown Object (File)
Sat, Mar 22, 3:41 PM
Unknown Object (File)
Sun, Mar 16, 11:58 PM
View All Files
Subscribers
ashoat

Details

Reviewers
michal
tomek
varun
• jon
Commits
rCOMMaf6356fc54c3: [feature-flags] Standardize localstack and http config
Summary
Test Plan

cargo run - should start with default localstack endpoint (LOCALSTACK_ENDPOINT env is set by Nix). Default HTTP port is 50055.
The --http-port and --localstack-endpoint arguments do override the defaults.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Sep 12 2023, 12:05 AM
bartek held this revision as a draft.
Herald added a reviewer: • jon. · View Herald TranscriptSep 12 2023, 12:05 AM
Herald added a subscriber: ashoat. · View Herald Transcript
bartek added a child revision: D9139: [feature-flags] Use default HTTP port for deployments.Sep 12 2023, 12:13 AM
bartek updated this revision to Diff 30950.Sep 12 2023, 12:21 AM

Fix --http-port

bartek published this revision for review.Sep 12 2023, 12:22 AM
bartek added inline comments.
services/feature-flags/Dockerfile
35–36 ↗(On Diff #30950)

This gets addressed in the next diff (D9139)
because it requires a new deployment

Harbormaster completed remote builds in B22511: Diff 30948.Sep 12 2023, 12:24 AM
michal accepted this revision.Sep 12 2023, 12:27 AM
This revision is now accepted and ready to land.Sep 12 2023, 12:27 AM
Harbormaster completed remote builds in B22513: Diff 30950.Sep 12 2023, 12:39 AM
Closed by commit rCOMMaf6356fc54c3: [feature-flags] Standardize localstack and http config (authored by bartek). · Explain WhySep 12 2023, 10:59 PM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMaf6356fc54c3: [feature-flags] Standardize localstack and http config.

Revision Contents
Changeset List

PathSize
services/
feature-flags/
3 lines
src/
31 lines
4 lines
6 lines

Diff 31022

View Options

services/feature-flags/Dockerfile

FROM commapp/services-base:1.3.2 as builder FROM rust:1.70-bullseye as builder
ENV PATH=/root/.cargo/bin:$PATH RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
build-essential cmake git libgtest-dev libssl-dev zlib1g-dev \
# Install Curl
RUN apt-get update \
&& DEBIAN_FRONTEND=noninteractive apt-get install -y curl \
&& rm -rf /var/lib/apt/lists/* && rm -rf /var/lib/apt/lists/*
# Install Rust WORKDIR /home/root/app/feature-flags
RUN curl https://sh.rustup.rs -sSf | sh -s -- -y
RUN mkdir -p /home/comm/app/feature-flags
WORKDIR /home/comm/app/feature-flags
RUN cargo init --bin
# Cache build dependencies in a new layer ENV CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse
COPY services/blob/Cargo.toml services/blob/Cargo.lock ./
COPY services/comm-services-lib ../comm-services-lib
RUN cargo build --release
# Copy actual application sources # Copy actual application sources
COPY services/feature-flags . COPY services/comm-services-lib ../comm-services-lib
COPY services/feature-flags ./
# Remove the previously-built binary so that only the application itself is RUN cargo install --locked --path .
# rebuilt
RUN rm -f ./target/release/deps/feature-flags*
RUN cargo build --release
# Runner stage # Runner stage
FROM commapp/services-base:1.3.2 as runner FROM debian:bullseye-slim as runner
# Create a new user comm and use it to run subsequent commands # Update dependencies, install ca-certificates which are required for TLS
RUN useradd -m comm RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
USER comm ca-certificates \
&& rm -rf /var/lib/apt/lists/*
# Only copy built binary from builder stage # Only copy built binary from builder stage
COPY --from=builder /usr/local/cargo/bin/feature-flags /usr/local/bin/feature-flags
WORKDIR /home/comm/app/feature-flags WORKDIR /home/comm/app/feature-flags
COPY --from=builder /home/comm/app/feature-flags/target/release/feature-flags .
ARG COMM_SERVICES_SANDBOX # Create a new user comm and use it to run subsequent commands
ENV COMM_SERVICES_SANDBOX=${COMM_SERVICES_SANDBOX} RUN useradd -m comm
USER comm
ENV RUST_LOG=info
CMD ./feature-flags CMD ["feature-flags"]
View Options

services/feature-flags/src/config.rs

FROM commapp/services-base:1.3.2 as builder FROM rust:1.70-bullseye as builder
ENV PATH=/root/.cargo/bin:$PATH RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
build-essential cmake git libgtest-dev libssl-dev zlib1g-dev \
# Install Curl
RUN apt-get update \
&& DEBIAN_FRONTEND=noninteractive apt-get install -y curl \
&& rm -rf /var/lib/apt/lists/* && rm -rf /var/lib/apt/lists/*
# Install Rust WORKDIR /home/root/app/feature-flags
RUN curl https://sh.rustup.rs -sSf | sh -s -- -y
RUN mkdir -p /home/comm/app/feature-flags
WORKDIR /home/comm/app/feature-flags
RUN cargo init --bin
# Cache build dependencies in a new layer ENV CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse
COPY services/blob/Cargo.toml services/blob/Cargo.lock ./
COPY services/comm-services-lib ../comm-services-lib
RUN cargo build --release
# Copy actual application sources # Copy actual application sources
COPY services/feature-flags . COPY services/comm-services-lib ../comm-services-lib
COPY services/feature-flags ./
# Remove the previously-built binary so that only the application itself is RUN cargo install --locked --path .
# rebuilt
RUN rm -f ./target/release/deps/feature-flags*
RUN cargo build --release
# Runner stage # Runner stage
FROM commapp/services-base:1.3.2 as runner FROM debian:bullseye-slim as runner
# Create a new user comm and use it to run subsequent commands # Update dependencies, install ca-certificates which are required for TLS
RUN useradd -m comm RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
USER comm ca-certificates \
&& rm -rf /var/lib/apt/lists/*
# Only copy built binary from builder stage # Only copy built binary from builder stage
COPY --from=builder /usr/local/cargo/bin/feature-flags /usr/local/bin/feature-flags
WORKDIR /home/comm/app/feature-flags WORKDIR /home/comm/app/feature-flags
COPY --from=builder /home/comm/app/feature-flags/target/release/feature-flags .
ARG COMM_SERVICES_SANDBOX # Create a new user comm and use it to run subsequent commands
ENV COMM_SERVICES_SANDBOX=${COMM_SERVICES_SANDBOX} RUN useradd -m comm
USER comm
ENV RUST_LOG=info
CMD ./feature-flags CMD ["feature-flags"]
View Options

services/feature-flags/src/constants.rs

FROM commapp/services-base:1.3.2 as builder FROM rust:1.70-bullseye as builder
ENV PATH=/root/.cargo/bin:$PATH RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
build-essential cmake git libgtest-dev libssl-dev zlib1g-dev \
# Install Curl
RUN apt-get update \
&& DEBIAN_FRONTEND=noninteractive apt-get install -y curl \
&& rm -rf /var/lib/apt/lists/* && rm -rf /var/lib/apt/lists/*
# Install Rust WORKDIR /home/root/app/feature-flags
RUN curl https://sh.rustup.rs -sSf | sh -s -- -y
RUN mkdir -p /home/comm/app/feature-flags
WORKDIR /home/comm/app/feature-flags
RUN cargo init --bin
# Cache build dependencies in a new layer ENV CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse
COPY services/blob/Cargo.toml services/blob/Cargo.lock ./
COPY services/comm-services-lib ../comm-services-lib
RUN cargo build --release
# Copy actual application sources # Copy actual application sources
COPY services/feature-flags . COPY services/comm-services-lib ../comm-services-lib
COPY services/feature-flags ./
# Remove the previously-built binary so that only the application itself is RUN cargo install --locked --path .
# rebuilt
RUN rm -f ./target/release/deps/feature-flags*
RUN cargo build --release
# Runner stage # Runner stage
FROM commapp/services-base:1.3.2 as runner FROM debian:bullseye-slim as runner
# Create a new user comm and use it to run subsequent commands # Update dependencies, install ca-certificates which are required for TLS
RUN useradd -m comm RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
USER comm ca-certificates \
&& rm -rf /var/lib/apt/lists/*
# Only copy built binary from builder stage # Only copy built binary from builder stage
COPY --from=builder /usr/local/cargo/bin/feature-flags /usr/local/bin/feature-flags
WORKDIR /home/comm/app/feature-flags WORKDIR /home/comm/app/feature-flags
COPY --from=builder /home/comm/app/feature-flags/target/release/feature-flags .
ARG COMM_SERVICES_SANDBOX # Create a new user comm and use it to run subsequent commands
ENV COMM_SERVICES_SANDBOX=${COMM_SERVICES_SANDBOX} RUN useradd -m comm
USER comm
ENV RUST_LOG=info
CMD ./feature-flags CMD ["feature-flags"]
View Options

services/feature-flags/src/service.rs

FROM commapp/services-base:1.3.2 as builder FROM rust:1.70-bullseye as builder
ENV PATH=/root/.cargo/bin:$PATH RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
build-essential cmake git libgtest-dev libssl-dev zlib1g-dev \
# Install Curl
RUN apt-get update \
&& DEBIAN_FRONTEND=noninteractive apt-get install -y curl \
&& rm -rf /var/lib/apt/lists/* && rm -rf /var/lib/apt/lists/*
# Install Rust WORKDIR /home/root/app/feature-flags
RUN curl https://sh.rustup.rs -sSf | sh -s -- -y
RUN mkdir -p /home/comm/app/feature-flags
WORKDIR /home/comm/app/feature-flags
RUN cargo init --bin
# Cache build dependencies in a new layer ENV CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse
COPY services/blob/Cargo.toml services/blob/Cargo.lock ./
COPY services/comm-services-lib ../comm-services-lib
RUN cargo build --release
# Copy actual application sources # Copy actual application sources
COPY services/feature-flags . COPY services/comm-services-lib ../comm-services-lib
COPY services/feature-flags ./
# Remove the previously-built binary so that only the application itself is RUN cargo install --locked --path .
# rebuilt
RUN rm -f ./target/release/deps/feature-flags*
RUN cargo build --release
# Runner stage # Runner stage
FROM commapp/services-base:1.3.2 as runner FROM debian:bullseye-slim as runner
# Create a new user comm and use it to run subsequent commands # Update dependencies, install ca-certificates which are required for TLS
RUN useradd -m comm RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
USER comm ca-certificates \
&& rm -rf /var/lib/apt/lists/*
# Only copy built binary from builder stage # Only copy built binary from builder stage
COPY --from=builder /usr/local/cargo/bin/feature-flags /usr/local/bin/feature-flags
WORKDIR /home/comm/app/feature-flags WORKDIR /home/comm/app/feature-flags
COPY --from=builder /home/comm/app/feature-flags/target/release/feature-flags .
ARG COMM_SERVICES_SANDBOX # Create a new user comm and use it to run subsequent commands
ENV COMM_SERVICES_SANDBOX=${COMM_SERVICES_SANDBOX} RUN useradd -m comm
USER comm
ENV RUST_LOG=info
CMD ./feature-flags CMD ["feature-flags"]