Page MenuHomePhabricator
Differential D9139

[feature-flags] Use default HTTP port for deployments
ClosedPublic
Actions

Authored by bartek on Sep 12 2023, 12:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 4, 3:39 AM
Unknown Object (File)
Mon, Oct 28, 6:44 PM
Unknown Object (File)
Sun, Oct 27, 4:26 PM
Unknown Object (File)
Sun, Oct 27, 4:26 PM
Unknown Object (File)
Sun, Oct 27, 4:26 PM
Unknown Object (File)
Sun, Oct 27, 4:26 PM
Unknown Object (File)
Sun, Oct 27, 4:26 PM
Unknown Object (File)
Sun, Oct 27, 4:25 PM
View All Files
Subscribers
ashoat

Details

Reviewers
michal
tomek
varun
• jon
Commits
rCOMM993b9cbd3d02: [feature-flags] Use default HTTP port for deployments
Summary

Deploy feature-flags service with new default HTTP port

NOTE: Applying the terraform changes requires rebuilding the docker image first! See the test plan.

Depends on D9138

Test Plan

On Staging:

  1. Build new docker image for feature-flags (latest tag)
  2. Apply terraform

Repeat on prod right before landing, with 0.1.1 docker tag

In case of problems, revert this and terraform apply again - this will revert deployment back to the existing v0.1

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Sep 12 2023, 12:13 AM
bartek held this revision as a draft.
Herald added a reviewer: • jon. · View Herald TranscriptSep 12 2023, 12:13 AM
Herald added a subscriber: ashoat. · View Herald Transcript
bartek published this revision for review.Sep 12 2023, 12:22 AM
bartek mentioned this in D9138: [feature-flags] Standardize localstack and http config.
bartek edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B22512: Diff 30949.Sep 12 2023, 12:29 AM
michal added a comment.Sep 12 2023, 12:34 AM

Should we also update the docker-compose.yml to use the new port?

About the applying terraform issue: maybe I'm misunderstanding something but couldn't we just bump the service version?

bartek planned changes to this revision.Sep 12 2023, 9:22 AM
bartek edited the test plan for this revision. (Show Details)Sep 12 2023, 11:09 PM
bartek updated this revision to Diff 31023.Sep 12 2023, 11:09 PM

Use separate tag for staging, bump prod version

Harbormaster completed remote builds in B22572: Diff 31023.Sep 12 2023, 11:27 PM
bartek added a child revision: D9176: [docker-compose] Match version tags with terraform.Sep 12 2023, 11:34 PM
michal accepted this revision.Sep 13 2023, 12:44 AM

Should we also update the docker-compose.yml to use the new port?

This revision is now accepted and ready to land.Sep 13 2023, 12:44 AM
bartek added a comment.Sep 13 2023, 12:46 AM
In D9139#269877, @michal wrote:

Should we also update the docker-compose.yml to use the new port?

yes, I forgot to change it 🙄

bartek updated this revision to Diff 31029.Sep 13 2023, 3:52 AM

Update port in docker-compose

Harbormaster completed remote builds in B22578: Diff 31029.Sep 13 2023, 4:10 AM
Closed by commit rCOMM993b9cbd3d02: [feature-flags] Use default HTTP port for deployments (authored by bartek). · Explain WhySep 13 2023, 4:26 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM993b9cbd3d02: [feature-flags] Use default HTTP port for deployments.

Revision Contents
Changeset List

PathSize
services/
4 lines
feature-flags/
3 lines
terraform/
remote/
6 lines

Diff 31031

View Options

services/docker-compose.yml

Loading...
View Options

services/feature-flags/Dockerfile

Loading...
View Options

services/terraform/remote/service_feature_flags.tf

Loading...