Apply shared identity client back to rust-node-addon to
verify that it works. Also cleans up the code quite a bit.
Related to: https://linear.app/comm/issue/ENG-4640
Depends on D8804
Details
Details
- Reviewers
bartek • jon - Commits
- rCOMM269eddc91b6b: [Keyserver/rust] Used shared identity client
- Run identity service and localstack
- Verify that keyserver can login to identity service upon start
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- jonringer/identity-client (branched from master)
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| keyserver/Dockerfile | ||
|---|---|---|
| 136 | Is this really necessary? I'm afraid it will hurt performance of the Docker build here. Do we really need everything in shared/, or can we copy over what we need piecemeal? | |
| keyserver/Dockerfile | ||
|---|---|---|
| 136 | Also please try to keep things consistent in this file. All other COPY commands omit the trailing slash on the first parameter | |
| keyserver/Dockerfile | ||
|---|---|---|
| 136 | We need all but cmake and tunnelbroker_messages, and the size of the folders is pretty small on a clean checkout: $ du -hd0 ./* 4.0K ./cmake 72K ./comm-opaque2 68K ./grpc_clients 28K ./protos 28K ./tunnelbroker_messages I just added another COPY command to keep the preference toward copying as little as needed. | |
| 136 | TIL this is to avoid issues with symlinks: https://stackoverflow.com/questions/18158248/should-i-put-trailing-slash-after-source-and-destination-when-copy-folders | |
Comment Actions
I assume this work is necessary for the keyserver to be able to connect to the identity service. @varun, is that right? If so, I think you'll need to commandeer it.