Page MenuHomePhabricator

[blob-service] Standardize localstack config
ClosedPublic

Authored by bartek on Aug 16 2023, 8:12 AM.
Tags
None
Referenced Files
F3370813: D8835.id29965.diff
Tue, Nov 26, 4:06 AM
F3369103: D8835.id30017.diff
Mon, Nov 25, 9:46 PM
Unknown Object (File)
Fri, Nov 22, 10:17 AM
Unknown Object (File)
Sun, Oct 27, 4:35 PM
Unknown Object (File)
Oct 25 2024, 1:12 AM
Unknown Object (File)
Sep 27 2024, 10:56 PM
Unknown Object (File)
Sep 27 2024, 10:56 PM
Unknown Object (File)
Sep 27 2024, 10:56 PM
Subscribers

Details

Summary

We should have one standard way of configuring localstack endpoint for all services. This diff standardizes the localstack config for blob-service.
I consider Tunnelbroker as state-of-the-art solution for localstack endpoint configuration.

TL;DR

cargo run -- --sandbox --localstack-url "http://localhost:4566"

-->

cargo run

The LOCALSTACK_ENDPOINT env variable is automatically provided by Nix so no need to specify --localstack-endpoint explicitly.

Test Plan

Ran the above command and it worked. Blob service integration tests are working.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Aug 16 2023, 8:50 AM
services/blob/src/s3.rs
110 ↗(On Diff #29965)

Possibly make a helper function for checking this?

services/blob/src/s3.rs
110 ↗(On Diff #29965)

I don't think that's really useful just for two places

services/blob/src/config.rs
7–8 ↗(On Diff #29965)

Can these two constants be cleaned up?

services/blob/src/config.rs
7–8 ↗(On Diff #29965)

lol their removal didn't commit, good catch, I was about to land this