Differential D8913
[native] introduce profileLarge avatar size Authored by ginsu on Aug 22 2023, 9:00 AM. Tags None Referenced Files
Details
In the profiles design we introduce a new avatar size (90 x 90). The closest size we had that could match was profile but it is 112x112. Ted and I tried using 112x112, but agreed that it was too big. I figured that the best approach here would be to make the profile size be 90x90, and introduced profileLarge that would be 112x112 (the old profile size).  flow and confirmed in all places where we rendered an avatar with the profile size that there were no regressions when I updated them
Diff Detail
Event Timeline
Comment Actions IMO it's a little confusing that we have like generic micro and small but then also usage specific profile size names. Personally would prefer something "standard" so progression of sizes is clear. Like it's not super clear where profile sits relative to eg small and large. Linear uses "T-Shirt sizes" like XS, S, M, L, XL, XLL, etc. which may be a better approach? Not a huge deal, but maybe something to think about when we're creating variants of components in design system Comment Actions https://linear.app/comm/issue/ENG-4815/update-avatar-size-variants-to-use-t-shirt-sizes Created this linear task to track your feedback. Will try and get to it later this week | ||||||||||||||||||||||||||||||||||||||