Paths

Table of Contentst

Differential D9364

[native] update avatar size variants to use t-shirt sizes
ClosedPublic
Actions

Authored by ginsu on Oct 4 2023, 1:39 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 14, 7:26 AM

	Unknown Object (File)
	Thu, Nov 14, 7:26 AM

	Unknown Object (File)
	Thu, Nov 14, 7:26 AM

	Unknown Object (File)
	Thu, Nov 14, 7:25 AM

	Unknown Object (File)
	Thu, Nov 14, 7:08 AM

	Unknown Object (File)
	Tue, Oct 29, 10:26 AM

	Unknown Object (File)
	Oct 15 2024, 6:01 AM

	Unknown Object (File)
	Oct 15 2024, 6:01 AM

View All 83 Files

Subscribers

Details

Reviewers

atul
inka

Commits

rCOMMdf113b8f3846: [native] update avatar size variants to use t-shirt sizes

Summary

For the user profile avatar view, I plan to introduce a new avatar size. In D8913, @atul called out switching the names of the avatar sizes from this generic/usage convention to a uniform naming convention. Figured before I introduce this new size, it would be worthwhile now to address this feedback

https://linear.app/comm/issue/ENG-4815/update-avatar-size-variants-to-use-t-shirt-sizes

Test Plan

flow and confirmed that there were no regressions with the avatar sizes

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Oct 4 2023, 1:39 PM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 4 2023, 1:39 PM

ginsu edited the summary of this revision. (Show Details)Oct 4 2023, 1:40 PM

ginsu added reviewers: atul, inka.

ginsu edited the summary of this revision. (Show Details)

ginsu added a child revision: D9365: [lib/native] lift AvatarSize type into lib.Oct 4 2023, 1:52 PM

Harbormaster completed remote builds in B22982: Diff 31649.Oct 4 2023, 1:57 PM

ginsu requested review of this revision.Oct 4 2023, 1:57 PM

atul accepted this revision.Oct 4 2023, 5:08 PM

This revision is now accepted and ready to land.Oct 4 2023, 5:08 PM

rebase before landing

Harbormaster completed remote builds in B22994: Diff 31661.Oct 4 2023, 8:38 PM

Closed by commit rCOMMdf113b8f3846: [native] update avatar size variants to use t-shirt sizes (authored by ginsu). · Explain WhyOct 4 2023, 8:50 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMdf113b8f3846: [native] update avatar size variants to use t-shirt sizes.

ginsu mentioned this in D9407: [web] update web avatars to use t shirt sizes.Oct 8 2023, 11:23 PM

ginsu mentioned this in rCOMMbf1e34799dcd: [web] update web avatars to use t shirt sizes.Oct 16 2023, 10:58 PM

Revision Contents
Changeset List

Path

Size

native/

avatars/

avatar.react.js

79 lines

edit-thread-avatar.react.js

2 lines

edit-user-avatar.react.js

4 lines

emoji-avatar-creation.react.js

2 lines

chat/

chat-thread-list-item.react.js

2 lines

composed-message.react.js

2 lines

mention-typeahead-tooltip-button.react.js

7 lines

message-list-header-title.react.js

2 lines

message-reactions-modal.react.js

2 lines

message-tooltip-button-avatar.react.js

2 lines

settings/

thread-settings-child-thread.react.js

2 lines

thread-settings-member.react.js

2 lines

thread-settings-parent.react.js

2 lines

components/

thread-list-thread.react.js

2 lines

user-list-user.react.js

2 lines

navigation/

community-drawer-item.react.js

2 lines

profile/

relationship-list-item.react.js

2 lines

roles/

change-roles-screen.react.js

2 lines

user-profile/

user-profile.react.js

2 lines

Diff 31670

native/avatars/avatar.react.js

Loading...

native/avatars/edit-thread-avatar.react.js

Loading...

native/avatars/edit-user-avatar.react.js

Loading...

native/avatars/emoji-avatar-creation.react.js

Loading...

native/chat/chat-thread-list-item.react.js

Loading...

native/chat/composed-message.react.js

Loading...

native/chat/mention-typeahead-tooltip-button.react.js

Loading...

native/chat/message-list-header-title.react.js

Loading...

native/chat/message-reactions-modal.react.js

Loading...

native/chat/message-tooltip-button-avatar.react.js

Loading...

native/chat/settings/thread-settings-child-thread.react.js

Loading...

native/chat/settings/thread-settings-member.react.js

Loading...

native/chat/settings/thread-settings-parent.react.js

Loading...

native/components/thread-list-thread.react.js

Loading...

native/components/user-list-user.react.js

Loading...

native/navigation/community-drawer-item.react.js

Loading...

native/profile/relationship-list-item.react.js

Loading...

native/roles/change-roles-screen.react.js

Loading...

native/user-profile/user-profile.react.js

Loading...