Page MenuHomePhabricator
Differential D9013

[native] clean up profile UI for users with long usernames
ClosedPublic
Actions

Authored by ginsu on Aug 29 2023, 10:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 22, 3:18 PM
Unknown Object (File)
Sun, Sep 22, 3:13 PM
Unknown Object (File)
Sun, Sep 22, 5:35 AM
Unknown Object (File)
Sun, Sep 22, 5:33 AM
Unknown Object (File)
Sun, Sep 22, 4:32 AM
Unknown Object (File)
Sun, Sep 22, 4:12 AM
Unknown Object (File)
Sun, Sep 22, 4:05 AM
Unknown Object (File)
Sun, Sep 22, 1:09 AM
View All 76 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMMd229ffe588f9: [native] clean up profile UI for users with long usernames
Summary

As I was working, I encountered a situation where users with long usernames had a profile that was not correctly aligned/styled

Here are the designs for reference:

Screenshot 2023-08-29 at 1.13.01 PM.png (1×620 px, 109 KB)

Test Plan

Please see screenshots:

Before:

Screenshot 2023-08-29 at 1.08.52 PM.png (1×958 px, 373 KB)

After:

Screenshot 2023-08-29 at 1.09.06 PM.png (1×958 px, 371 KB)

Diff Detail

Repository
rCOMM Comm
Branch
eng-3998 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Aug 29 2023, 10:12 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 29 2023, 10:12 AM
ginsu published this revision for review.Aug 29 2023, 10:14 AM
ginsu edited the summary of this revision. (Show Details)
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu attached a referenced file: F730861: Screenshot 2023-08-29 at 1.09.06 PM.png. (Show Details)
ginsu attached a referenced file: F730859: Screenshot 2023-08-29 at 1.08.52 PM.png. (Show Details)
ginsu attached a referenced file: F730858: Screenshot 2023-08-29 at 1.13.01 PM.png. (Show Details)
Harbormaster completed remote builds in B22231: Diff 30515.Aug 29 2023, 10:30 AM
inka added a comment.Aug 30 2023, 12:53 AM

Can you use the SingleLine component?

ginsu updated this revision to Diff 30785.Sep 5 2023, 10:59 AM

address comments

ginsu added a child revision: D9090: [native] make SingleLine the default export.Sep 5 2023, 11:04 AM
Harbormaster completed remote builds in B22395: Diff 30785.Sep 5 2023, 11:17 AM
atul accepted this revision.Sep 6 2023, 2:00 PM
This revision is now accepted and ready to land.Sep 6 2023, 2:00 PM
ginsu updated this revision to Diff 30817.Sep 6 2023, 2:35 PM

rebase before landing

Harbormaster completed remote builds in B22418: Diff 30817.Sep 6 2023, 2:53 PM
Closed by commit rCOMMd229ffe588f9: [native] clean up profile UI for users with long usernames (authored by ginsu). · Explain WhySep 6 2023, 8:59 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMd229ffe588f9: [native] clean up profile UI for users with long usernames.

Revision Contents
Changeset List

PathSize
native/
components/
10 lines

Diff 30515

View Options

native/components/user-profile.react.js

Loading...