Page MenuHomePhabricator

[lib/native] Extract link parsing utils to lib
ClosedPublic

Authored by rohan on Aug 30 2023, 8:42 AM.
Tags
None
Referenced Files
F3374518: D9026.id30566.diff
Tue, Nov 26, 3:51 PM
F3369578: D9026.diff
Mon, Nov 25, 10:56 PM
Unknown Object (File)
Fri, Nov 22, 10:31 PM
Unknown Object (File)
Fri, Nov 22, 7:51 PM
Unknown Object (File)
Thu, Oct 31, 1:50 PM
Unknown Object (File)
Thu, Oct 31, 1:50 PM
Unknown Object (File)
Thu, Oct 31, 1:50 PM
Unknown Object (File)
Thu, Oct 31, 1:46 PM
Subscribers

Details

Summary

This is going to be done in preparation to unify all deep link handling logic on native since we now have two deep link cases to handle. The end goal is to have just one handler to reduce
boilerplate and similar behavior across different handlers.

This will also make it easy to handle a new link down the line. In this diff, I've just moved the parsing-specific functions to lib/facts/links.js alongside the methods that construct the links.

This is not part of a monthly goal, just a follow-up task.

Part of ENG-4810

Test Plan

Ran flow to make sure the types were still ok, ran the app to make sure the imports were correct, and made sure invite links and QR code links were still working.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable