Page MenuHomePhabricator
Differential D9087

[native] upgrade rn-emoji-keyboard to v1.5.1
ClosedPublic
Actions

Authored by ginsu on Sep 5 2023, 9:15 AM.
Tags
None
Referenced Files
F3529200: D9087.id30824.diff
Tue, Dec 24, 4:55 PM
F3527465: D9087.diff
Tue, Dec 24, 5:08 AM
Unknown Object (File)
Sat, Dec 21, 2:09 PM
Unknown Object (File)
Sat, Dec 21, 2:09 PM
Unknown Object (File)
Sat, Dec 21, 2:08 PM
Unknown Object (File)
Sat, Dec 21, 1:59 PM
Unknown Object (File)
Mon, Dec 9, 4:32 AM
Unknown Object (File)
Thu, Dec 5, 10:03 PM
View All 61 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
ashoat
kamil
Commits
rCOMM1d0d512bdb47: [native] upgrade rn-emoji-keyboard to v1.5.1
Summary

Our friends from rn-emoji-keyboard just released a new update to their emoji keyboard library which includes a fix for the bug mentioned in ENG-4277. This diff updates our usage of rn-emoji-keyboard to this latest version

Link to PR: https://github.com/TheWidlarzGroup/rn-emoji-keyboard/pull/149

Test Plan

Check out the demo video to see that keyboard is no longer blocking the bottom emojis when the keyboard is open

Diff Detail

Repository
rCOMM Comm
Branch
eng-4277
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Sep 5 2023, 9:15 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 5 2023, 9:15 AM
ginsu edited the summary of this revision. (Show Details)Sep 5 2023, 9:19 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, ashoat, kamil.
ginsu edited the test plan for this revision. (Show Details)
ginsu attached a referenced file: F743924: Screen Recording 2023-09-05 at 12.19.49 PM.mov. (Show Details)
ginsu attached a referenced file: F743919: Screen Recording 2023-09-05 at 12.16.35 PM.mov. (Show Details)

Made @ashoat blocking since this a dependency diff

Harbormaster completed remote builds in B22391: Diff 30780.Sep 5 2023, 9:33 AM
ginsu requested review of this revision.Sep 5 2023, 9:33 AM
atul accepted this revision.Sep 6 2023, 2:00 PM

Seems fine at a glance

ashoat accepted this revision.Sep 6 2023, 6:12 PM
This revision is now accepted and ready to land.Sep 6 2023, 6:12 PM
Closed by commit rCOMM1d0d512bdb47: [native] upgrade rn-emoji-keyboard to v1.5.1 (authored by ginsu). · Explain WhySep 6 2023, 9:01 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM1d0d512bdb47: [native] upgrade rn-emoji-keyboard to v1.5.1.

Revision Contents
Changeset List

PathSize
native/
2 lines
8 lines

Diff 30780

View Options

native/package.json

Loading...
View Options

yarn.lock

Loading...