[native] upgrade rn-emoji-keyboard to v1.5.1
ClosedPublic
Actions

Authored by ginsu on Sep 5 2023, 9:15 AM.

Details

Reviewers

atul
ashoat
kamil

Commits

rCOMM1d0d512bdb47: [native] upgrade rn-emoji-keyboard to v1.5.1

Summary

Our friends from rn-emoji-keyboard just released a new update to their emoji keyboard library which includes a fix for the bug mentioned in ENG-4277. This diff updates our usage of rn-emoji-keyboard to this latest version

Link to PR: https://github.com/TheWidlarzGroup/rn-emoji-keyboard/pull/149

Test Plan

Check out the demo video to see that keyboard is no longer blocking the bottom emojis when the keyboard is open

Diff Detail

Repository

rCOMM Comm

Branch

eng-4277

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Sep 5 2023, 9:15 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 5 2023, 9:15 AM

Made @ashoat blocking since this a dependency diff

Harbormaster completed remote builds in B22391: Diff 30780.Sep 5 2023, 9:33 AM

ginsu requested review of this revision.Sep 5 2023, 9:33 AM

Seems fine at a glance

ashoat accepted this revision.Sep 6 2023, 6:12 PM

This revision is now accepted and ready to land.Sep 6 2023, 6:12 PM

Closed by commit rCOMM1d0d512bdb47: [native] upgrade rn-emoji-keyboard to v1.5.1 (authored by ginsu). · Explain WhySep 6 2023, 9:01 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM1d0d512bdb47: [native] upgrade rn-emoji-keyboard to v1.5.1.

Revision Contents
Changeset List

Path

Size

native/

package.json

2 lines

yarn.lock

8 lines

Diff 30780

View Options

native/package.json