[web] remove glow effect for the message action tooltip
ClosedPublic
Actions

Authored by ginsu on Sep 5 2023, 10:33 AM.

Details

Reviewers

atul
kamil

Commits

rCOMMda3f3a2944d9: [web] remove glow effect for the message action tooltip

Summary

This addresses https://linear.app/comm/issue/ENG-4811/remove-glow-effect-for-the-message-action-tool-tip

Test Plan

Please see the before and after screenshots, also confirmed with @ted IRL and we both think this is an improvement visually

Before:

Screenshot 2023-09-05 at 1.30.32 PM.png (320×672 px, 39 KB)

After:

Screenshot 2023-09-05 at 1.31.03 PM.png (278×462 px, 18 KB)

Diff Detail

Repository

rCOMM Comm

Branch

eng-4811

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Sep 5 2023, 10:33 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 5 2023, 10:33 AM

ginsu edited the test plan for this revision. (Show Details)Sep 5 2023, 10:34 AM

ginsu added reviewers: atul, kamil.

ginsu attached a referenced file: F743986: Screenshot 2023-09-05 at 1.31.03 PM.png. (Show Details)

ginsu attached a referenced file: F743985: Screenshot 2023-09-05 at 1.30.32 PM.png. (Show Details)

Harbormaster completed remote builds in B22392: Diff 30781.Sep 5 2023, 10:52 AM

ginsu requested review of this revision.Sep 5 2023, 10:52 AM

Personally would prefer if in this same diff we opted for some sort of outline or shadow or anything to preserve the "depth" effect that the glow was supposed to provide

This revision is now accepted and ready to land.Sep 6 2023, 2:01 PM

Personally would prefer if in this same diff we opted for some sort of outline or shadow or anything to preserve the "depth" effect that the glow was supposed to provide

Going to land this now as is so that the message action tooltip can match how the reaction tooltip looks; however, I created this linear task for @ted to design this "depth" effect into the tooltips and will put up a follow up diff after that is done.

https://linear.app/comm/issue/DES-141/design-depth-effect-for-web-tooltips

rebase before landing

Harbormaster completed remote builds in B22420: Diff 30819.Sep 6 2023, 3:10 PM

Closed by commit rCOMMda3f3a2944d9: [web] remove glow effect for the message action tooltip (authored by ginsu). · Explain WhySep 6 2023, 8:58 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMda3f3a2944d9: [web] remove glow effect for the message action tooltip.