Page MenuHomePhabricator
Differential D9151

[native] Add expo-file-system dependency
ClosedPublic
Actions

Authored by • patryk on Sep 12 2023, 1:06 PM.
Tags
None
Referenced Files
F5096588: D9151.id30984.diff
Sun, Mar 30, 9:11 PM
Unknown Object (File)
Sun, Mar 23, 8:49 AM
Unknown Object (File)
Sun, Mar 23, 5:19 AM
Unknown Object (File)
Tue, Mar 11, 11:57 PM
Unknown Object (File)
Wed, Mar 5, 5:06 PM
Unknown Object (File)
Wed, Mar 5, 5:06 PM
Unknown Object (File)
Wed, Mar 5, 5:06 PM
Unknown Object (File)
Wed, Mar 5, 5:05 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
atul
ashoat
Commits
rCOMM7aea5c13119d: [native] Add expo-file-system dependency
Summary

This diff adds expo-file-system dependency to native package.json.

Test Plan

Checked if native app works.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• patryk created this revision.Sep 12 2023, 1:06 PM
• patryk held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 12 2023, 1:06 PM
Harbormaster completed remote builds in B22538: Diff 30984.Sep 12 2023, 1:25 PM
• patryk added a child revision: D9152: [native] Use expo-file-system uploads.Sep 12 2023, 1:43 PM
• patryk edited the summary of this revision. (Show Details)Sep 13 2023, 2:10 AM
• patryk edited the test plan for this revision. (Show Details)
• patryk updated this revision to Diff 31026.Sep 13 2023, 3:10 AM

Rebase

Harbormaster completed remote builds in B22575: Diff 31026.Sep 13 2023, 3:28 AM
• patryk published this revision for review.Sep 14 2023, 4:43 AM
• patryk added a reviewer: ashoat.
ashoat accepted this revision.Sep 14 2023, 8:32 AM
This revision is now accepted and ready to land.Sep 14 2023, 8:32 AM
Closed by commit rCOMM7aea5c13119d: [native] Add expo-file-system dependency (authored by • patryk). · Explain WhySep 15 2023, 6:23 AM
This revision was automatically updated to reflect the committed changes.
• patryk added a commit: rCOMM7aea5c13119d: [native] Add expo-file-system dependency.

Revision Contents
Changeset List

PathSize
native/
1 line
6 lines

Diff 31026

View Options

native/package.json

// @flow // @flow
import { useActionSheet } from '@expo/react-native-action-sheet'; import { useActionSheet } from '@expo/react-native-action-sheet';
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { View, Text, Platform } from 'react-native'; import { View, Text, Platform, ActivityIndicator } from 'react-native';
import { TouchableOpacity } from 'react-native-gesture-handler'; import { TouchableOpacity } from 'react-native-gesture-handler';
import { useSafeAreaInsets } from 'react-native-safe-area-context'; import { useSafeAreaInsets } from 'react-native-safe-area-context';
import { changeThreadMemberRolesActionTypes } from 'lib/actions/thread-actions.js';
import { createLoadingStatusSelector } from 'lib/selectors/loading-selectors.js';
import type { LoadingStatus } from 'lib/types/loading-types.js';
import type { RelativeMemberInfo, ThreadInfo } from 'lib/types/thread-types.js'; import type { RelativeMemberInfo, ThreadInfo } from 'lib/types/thread-types.js';
import { values } from 'lib/utils/objects.js'; import { values } from 'lib/utils/objects.js';
import ChangeRolesHeaderRightButton from './change-roles-header-right-button.react.js';
import UserAvatar from '../avatars/user-avatar.react.js'; import UserAvatar from '../avatars/user-avatar.react.js';
import type { ChatNavigationProp } from '../chat/chat.react'; import type { ChatNavigationProp } from '../chat/chat.react';
import SWMansionIcon from '../components/swmansion-icon.react.js'; import SWMansionIcon from '../components/swmansion-icon.react.js';
import type { NavigationRoute } from '../navigation/route-names.js'; import type { NavigationRoute } from '../navigation/route-names.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
import { useStyles } from '../themes/colors.js'; import { useStyles } from '../themes/colors.js';
export type ChangeRolesScreenParams = { export type ChangeRolesScreenParams = {
+threadInfo: ThreadInfo, +threadInfo: ThreadInfo,
+memberInfo: RelativeMemberInfo, +memberInfo: RelativeMemberInfo,
+role: ?string, +role: ?string,
}; };
type Props = { type Props = {
+navigation: ChatNavigationProp<'ChangeRolesScreen'>, +navigation: ChatNavigationProp<'ChangeRolesScreen'>,
+route: NavigationRoute<'ChangeRolesScreen'>, +route: NavigationRoute<'ChangeRolesScreen'>,
}; };
const changeRolesLoadingStatusSelector = createLoadingStatusSelector(
changeThreadMemberRolesActionTypes,
);
function ChangeRolesScreen(props: Props): React.Node { function ChangeRolesScreen(props: Props): React.Node {
const { navigation } = props; const { navigation, route } = props;
const { threadInfo, memberInfo, role } = props.route.params; const { threadInfo, memberInfo, role } = props.route.params;
invariant(role, 'Role must be defined'); invariant(role, 'Role must be defined');
const changeRolesLoadingStatus: LoadingStatus = useSelector(
changeRolesLoadingStatusSelector,
);
const activityIndicatorStyle = React.useMemo(
() => ({ paddingRight: 15 }),
[],
);
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const [selectedRole, setSelectedRole] = React.useState<string>(role); const [selectedRole, setSelectedRole] = React.useState<string>(role);
const roleOptions = React.useMemo( const roleOptions = React.useMemo(
() => () =>
values(threadInfo.roles).map(threadRole => ({ values(threadInfo.roles).map(threadRole => ({
id: threadRole.id, id: threadRole.id,
name: threadRole.name, name: threadRole.name,
▲ Show 20 Lines • Show All 55 Lines • ▼ Show 20 Linesfunction ChangeRolesScreen(props: Props): React.Node {
}, [ }, [
roleOptions, roleOptions,
onRoleChange, onRoleChange,
insets.bottom, insets.bottom,
activeTheme, activeTheme,
showActionSheetWithOptions, showActionSheetWithOptions,
]); ]);
React.useEffect(() => {
navigation.setOptions({
// eslint-disable-next-line react/display-name
headerRight: () => {
if (changeRolesLoadingStatus === 'loading') {
return (
<ActivityIndicator
size="small"
color="white"
style={activityIndicatorStyle}
/>
);
}
return <ChangeRolesHeaderRightButton route={route} />;
},
});
}, [changeRolesLoadingStatus, navigation, activityIndicatorStyle, route]);
return ( return (
<View> <View>
<View style={styles.descriptionBackground}> <View style={styles.descriptionBackground}>
<Text style={styles.descriptionText}> <Text style={styles.descriptionText}>
Members can only be assigned one role at a time. Changing a Members can only be assigned one role at a time. Changing a
member&rsquo;s role will replace their previously assigned role. member&rsquo;s role will replace their previously assigned role.
</Text> </Text>
</View> </View>
▲ Show 20 Lines • Show All 63 Lines • Show Last 20 Lines
View Options

yarn.lock

// @flow // @flow
import { useActionSheet } from '@expo/react-native-action-sheet'; import { useActionSheet } from '@expo/react-native-action-sheet';
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { View, Text, Platform } from 'react-native'; import { View, Text, Platform, ActivityIndicator } from 'react-native';
import { TouchableOpacity } from 'react-native-gesture-handler'; import { TouchableOpacity } from 'react-native-gesture-handler';
import { useSafeAreaInsets } from 'react-native-safe-area-context'; import { useSafeAreaInsets } from 'react-native-safe-area-context';
import { changeThreadMemberRolesActionTypes } from 'lib/actions/thread-actions.js';
import { createLoadingStatusSelector } from 'lib/selectors/loading-selectors.js';
import type { LoadingStatus } from 'lib/types/loading-types.js';
import type { RelativeMemberInfo, ThreadInfo } from 'lib/types/thread-types.js'; import type { RelativeMemberInfo, ThreadInfo } from 'lib/types/thread-types.js';
import { values } from 'lib/utils/objects.js'; import { values } from 'lib/utils/objects.js';
import ChangeRolesHeaderRightButton from './change-roles-header-right-button.react.js';
import UserAvatar from '../avatars/user-avatar.react.js'; import UserAvatar from '../avatars/user-avatar.react.js';
import type { ChatNavigationProp } from '../chat/chat.react'; import type { ChatNavigationProp } from '../chat/chat.react';
import SWMansionIcon from '../components/swmansion-icon.react.js'; import SWMansionIcon from '../components/swmansion-icon.react.js';
import type { NavigationRoute } from '../navigation/route-names.js'; import type { NavigationRoute } from '../navigation/route-names.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
import { useStyles } from '../themes/colors.js'; import { useStyles } from '../themes/colors.js';
export type ChangeRolesScreenParams = { export type ChangeRolesScreenParams = {
+threadInfo: ThreadInfo, +threadInfo: ThreadInfo,
+memberInfo: RelativeMemberInfo, +memberInfo: RelativeMemberInfo,
+role: ?string, +role: ?string,
}; };
type Props = { type Props = {
+navigation: ChatNavigationProp<'ChangeRolesScreen'>, +navigation: ChatNavigationProp<'ChangeRolesScreen'>,
+route: NavigationRoute<'ChangeRolesScreen'>, +route: NavigationRoute<'ChangeRolesScreen'>,
}; };
const changeRolesLoadingStatusSelector = createLoadingStatusSelector(
changeThreadMemberRolesActionTypes,
);
function ChangeRolesScreen(props: Props): React.Node { function ChangeRolesScreen(props: Props): React.Node {
const { navigation } = props; const { navigation, route } = props;
const { threadInfo, memberInfo, role } = props.route.params; const { threadInfo, memberInfo, role } = props.route.params;
invariant(role, 'Role must be defined'); invariant(role, 'Role must be defined');
const changeRolesLoadingStatus: LoadingStatus = useSelector(
changeRolesLoadingStatusSelector,
);
const activityIndicatorStyle = React.useMemo(
() => ({ paddingRight: 15 }),
[],
);
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const [selectedRole, setSelectedRole] = React.useState<string>(role); const [selectedRole, setSelectedRole] = React.useState<string>(role);
const roleOptions = React.useMemo( const roleOptions = React.useMemo(
() => () =>
values(threadInfo.roles).map(threadRole => ({ values(threadInfo.roles).map(threadRole => ({
id: threadRole.id, id: threadRole.id,
name: threadRole.name, name: threadRole.name,
▲ Show 20 Lines • Show All 55 Lines • ▼ Show 20 Linesfunction ChangeRolesScreen(props: Props): React.Node {
}, [ }, [
roleOptions, roleOptions,
onRoleChange, onRoleChange,
insets.bottom, insets.bottom,
activeTheme, activeTheme,
showActionSheetWithOptions, showActionSheetWithOptions,
]); ]);
React.useEffect(() => {
navigation.setOptions({
// eslint-disable-next-line react/display-name
headerRight: () => {
if (changeRolesLoadingStatus === 'loading') {
return (
<ActivityIndicator
size="small"
color="white"
style={activityIndicatorStyle}
/>
);
}
return <ChangeRolesHeaderRightButton route={route} />;
},
});
}, [changeRolesLoadingStatus, navigation, activityIndicatorStyle, route]);
return ( return (
<View> <View>
<View style={styles.descriptionBackground}> <View style={styles.descriptionBackground}>
<Text style={styles.descriptionText}> <Text style={styles.descriptionText}>
Members can only be assigned one role at a time. Changing a Members can only be assigned one role at a time. Changing a
member&rsquo;s role will replace their previously assigned role. member&rsquo;s role will replace their previously assigned role.
</Text> </Text>
</View> </View>
▲ Show 20 Lines • Show All 63 Lines • Show Last 20 Lines