Page MenuHomePhabricator
Differential D9154

[lib] Add uuid dependency
ClosedPublic
Actions

Authored by • patryk on Sep 12 2023, 1:45 PM.
Tags
None
Referenced Files
F3180660: D9154.id30988.diff
Fri, Nov 8, 5:07 AM
Unknown Object (File)
Sun, Nov 3, 5:21 AM
Unknown Object (File)
Thu, Oct 31, 1:14 PM
Unknown Object (File)
Thu, Oct 31, 1:14 PM
Unknown Object (File)
Thu, Oct 31, 1:14 PM
Unknown Object (File)
Thu, Oct 31, 1:14 PM
Unknown Object (File)
Fri, Oct 25, 8:56 PM
Unknown Object (File)
Tue, Oct 15, 7:23 PM
View All 74 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
atul
ashoat
Commits
rCOMM2904579fc7a0: [lib] Add uuid dependency
Summary

This diff adds uuid dependency to lib. This is necessary since blob upload function will be moved to lib.

Depends on D9152.

Test Plan

Tested later in the stack

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• patryk created this revision.Sep 12 2023, 1:45 PM
• patryk held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 12 2023, 1:45 PM
Harbormaster completed remote builds in B22542: Diff 30988.Sep 12 2023, 2:04 PM
• patryk added a child revision: D9157: [lib] Add blobServiceUpload upload action.Sep 13 2023, 2:55 AM
• patryk published this revision for review.Sep 14 2023, 4:45 AM
atul accepted this revision.Sep 14 2023, 9:07 AM
atul added a reviewer: ashoat.

Seems reasonable. In the future it might be helpful to provide link to corresponding GitHub repo in description.

Adding @ashoat as blocking reviewer since this is dependency diff.

ashoat accepted this revision.Sep 14 2023, 9:12 AM
This revision is now accepted and ready to land.Sep 14 2023, 9:12 AM
Closed by commit rCOMM2904579fc7a0: [lib] Add uuid dependency (authored by • patryk). · Explain WhySep 15 2023, 6:24 AM
This revision was automatically updated to reflect the committed changes.
• patryk added a commit: rCOMM2904579fc7a0: [lib] Add uuid dependency.

Revision Contents
Changeset List

PathSize
lib/
5 lines

Diff 31173

View Options

lib/package.json

Loading...