Page MenuHomePhabricator
Differential D9251

[keyserver] Remove unused exports in message-fetchers.js
ClosedPublic
Actions

Authored by ashoat on Sep 20 2023, 11:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 11, 3:24 PM
Unknown Object (File)
Thu, Jan 30, 7:28 PM
Unknown Object (File)
Thu, Jan 30, 7:28 PM
Unknown Object (File)
Thu, Jan 30, 7:23 PM
Unknown Object (File)
Thu, Jan 30, 12:02 PM
Unknown Object (File)
Sat, Jan 25, 2:44 AM
Unknown Object (File)
Thu, Jan 23, 10:47 PM
Unknown Object (File)
Thu, Jan 23, 10:47 PM
View All 88 Files
Subscribers
atul
rohan
tomek

Details

Reviewers
rohan
inka
Commits
rCOMMa301a42f0654: [keyserver] Remove unused exports in message-fetchers.js
Summary

Noticed these unused exports during a 1:1 with @rohan

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/unusedexport
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Sep 20 2023, 11:59 AM
Herald added a subscriber: tomek. · View Herald TranscriptSep 20 2023, 11:59 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Sep 20 2023, 12:33 PM
Harbormaster failed remote builds in B22767: Diff 31325!
ashoat requested review of this revision.Sep 20 2023, 1:31 PM

Android failure is unrelated

atul added a subscriber: atul.Sep 20 2023, 1:53 PM
In D9251#272216, @ashoat wrote:

Android failure is unrelated

Ah dang looks like network issues with dependencies. Maybe we should be spacing retries out a bit more (maybe first retry is instant and subsequent ones are spaced out w/ some backoff?)

Harbormaster completed remote builds in B22767: Diff 31325.Sep 20 2023, 2:02 PM
rohan accepted this revision.Sep 21 2023, 8:40 AM
This revision is now accepted and ready to land.Sep 21 2023, 8:40 AM
Closed by commit rCOMMa301a42f0654: [keyserver] Remove unused exports in message-fetchers.js (authored by ashoat). · Explain WhySep 21 2023, 9:01 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMa301a42f0654: [keyserver] Remove unused exports in message-fetchers.js.

Revision Contents
Changeset List

PathSize
keyserver/
src/
fetchers/
2 lines

Diff 31325

View Options

keyserver/src/fetchers/message-fetchers.js

Loading...