Page MenuHomePhabricator
Differential D9293

Add brotli.js library
ClosedPublic
Actions

Authored by ashoat on Sep 25 2023, 1:34 PM.
Tags
None
Referenced Files
F3383754: D9293.id31430.diff
Thu, Nov 28, 5:32 PM
Unknown Object (File)
Mon, Nov 25, 3:15 AM
Unknown Object (File)
Mon, Nov 25, 12:27 AM
Unknown Object (File)
Wed, Nov 20, 4:39 PM
Unknown Object (File)
Wed, Nov 20, 4:39 PM
Unknown Object (File)
Wed, Nov 20, 4:39 PM
Unknown Object (File)
Wed, Nov 20, 4:37 PM
Unknown Object (File)
Wed, Nov 20, 4:18 PM
View All Files
Subscribers
tomek

Details

Reviewers
atul
michal
kamil
Commits
rCOMM660d195cb003: Add brotli.js library
Summary

Brotli is a compression algorithm from Google that has similar performance and better compression than Zlib. I'm going to use it in the following diff to compress keyserver -> client socket messages.

Test Plan

Tested in combination with the following diff

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Sep 25 2023, 1:34 PM
Herald added a subscriber: tomek. · View Herald TranscriptSep 25 2023, 1:34 PM
ashoat added a child revision: D9294: Introduce Brotli compression for keyserver -> client socket messages.Sep 25 2023, 1:36 PM
Harbormaster completed remote builds in B22841: Diff 31416.Sep 25 2023, 1:53 PM
ashoat requested review of this revision.Sep 25 2023, 1:53 PM
atul requested changes to this revision.Sep 26 2023, 10:10 AM

Can we leverage Brotli compression/decompression functionality that's built into Node/Zlib instead of introducing a new dependency?

It seems like it has the compress/decompress functionality that we need:

07343e.png (1×2 px, 493 KB)

This revision now requires changes to proceed.Sep 26 2023, 10:10 AM
ashoat updated this revision to Diff 31425.Sep 26 2023, 12:45 PM

Remove brotli.js from keyserver in favor of built-in Node.js utility from zlib library

Harbormaster completed remote builds in B22847: Diff 31425.Sep 26 2023, 1:05 PM
atul added a comment.EditedSep 26 2023, 1:26 PM

This can be abandoned now?

JK, still need it for eg native

atul accepted this revision.Sep 26 2023, 1:27 PM
This revision is now accepted and ready to land.Sep 26 2023, 1:27 PM
Closed by commit rCOMM660d195cb003: Add brotli.js library (authored by ashoat). · Explain WhySep 26 2023, 1:43 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM660d195cb003: Add brotli.js library.

Revision Contents
Changeset List

PathSize
keyserver/
1 line
native/
1 line
web/
1 line
7 lines

Diff 31416

View Options

keyserver/package.json

Loading...
View Options

native/package.json

Loading...
View Options

web/package.json

Loading...
View Options

yarn.lock

Loading...