Page MenuHomePhabricator

Add brotli.js library
ClosedPublic

Authored by ashoat on Sep 25 2023, 1:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 4, 3:45 AM
Unknown Object (File)
Fri, Nov 1, 12:06 PM
Unknown Object (File)
Tue, Oct 29, 2:04 AM
Unknown Object (File)
Sat, Oct 19, 4:20 AM
Unknown Object (File)
Sat, Oct 19, 4:20 AM
Unknown Object (File)
Sat, Oct 19, 4:20 AM
Unknown Object (File)
Sat, Oct 19, 4:18 AM
Unknown Object (File)
Sat, Oct 19, 4:01 AM
Subscribers

Details

Summary

Brotli is a compression algorithm from Google that has similar performance and better compression than Zlib. I'm going to use it in the following diff to compress keyserver -> client socket messages.

Test Plan

Tested in combination with the following diff

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul requested changes to this revision.Sep 26 2023, 10:10 AM

Can we leverage Brotli compression/decompression functionality that's built into Node/Zlib instead of introducing a new dependency?

It seems like it has the compress/decompress functionality that we need:

07343e.png (1×2 px, 493 KB)

This revision now requires changes to proceed.Sep 26 2023, 10:10 AM

Remove brotli.js from keyserver in favor of built-in Node.js utility from zlib library

This can be abandoned now?

JK, still need it for eg native

This revision is now accepted and ready to land.Sep 26 2023, 1:27 PM
This revision was automatically updated to reflect the committed changes.