Page MenuHomePhabricator
Differential D9333

[native] Remove threadMembersWithoutAddedAshoat check for ThreadInfo
ClosedPublic
Actions

Authored by ashoat on Sep 29 2023, 11:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 2, 7:59 PM
Unknown Object (File)
Wed, Apr 2, 7:40 AM
Unknown Object (File)
Mon, Mar 24, 2:16 PM
Unknown Object (File)
Mon, Mar 24, 2:16 PM
Unknown Object (File)
Sun, Mar 23, 9:03 AM
Unknown Object (File)
Sat, Mar 8, 9:49 AM
Unknown Object (File)
Mar 5 2025, 2:03 AM
Unknown Object (File)
Mar 3 2025, 7:15 AM
View All Files
Subscribers
tomek

Details

Reviewers
atul
rohan
michal
Commits
rCOMM5bb5a97953f3: [native] Remove threadMembersWithoutAddedAshoat check for ThreadInfo
Summary

After working on D9332, I looked around for other cases where we were passing a ThreadInfo to threadMembersWithoutAddedAshoat, since that is a no-op. I found one other such case, so I decided to remove it.

Depends on D9332

Test Plan

Careful reading and Flow

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/group-chat
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
chat/
8 lines

Diff 31564

View Options

native/chat/chat.react.js

Show All 20 Lines
import { import {
useServerCall, useServerCall,
useDispatchActionPromise, useDispatchActionPromise,
} from 'lib/utils/action-utils'; } from 'lib/utils/action-utils';
import MenuItem from '../components/menu-item.react'; import MenuItem from '../components/menu-item.react';
import Menu from '../components/menu.react'; import Menu from '../components/menu.react';
import SidebarListModal from '../modals/chat/sidebar-list-modal.react'; import SidebarListModal from '../modals/chat/sidebar-list-modal.react';
import SidebarPromoteModal from '../modals/chat/sidebar-promote-modal.react';
import { useModalContext } from '../modals/modal-provider.react'; import { useModalContext } from '../modals/modal-provider.react';
import ConfirmLeaveThreadModal from '../modals/threads/confirm-leave-thread-modal.react'; import ConfirmLeaveThreadModal from '../modals/threads/confirm-leave-thread-modal.react';
import ThreadMembersModal from '../modals/threads/members/members-modal.react'; import ThreadMembersModal from '../modals/threads/members/members-modal.react';
import SubchannelsModal from '../modals/threads/subchannels/subchannels-modal.react'; import SubchannelsModal from '../modals/threads/subchannels/subchannels-modal.react';
import ThreadSettingsModal from '../modals/threads/thread-settings-modal.react'; import ThreadSettingsModal from '../modals/threads/thread-settings-modal.react';
import { useSelector } from '../redux/redux-utils'; import { useSelector } from '../redux/redux-utils';
import SWMansionIcon from '../SWMansionIcon.react'; import SWMansionIcon from '../SWMansionIcon.react';
import css from './thread-menu.css'; import css from './thread-menu.css';
▲ Show 20 Lines • Show All 154 Lines • ▼ Show 20 Lines return (
text="Leave Thread" text="Leave Thread"
icon="logout" icon="logout"
dangerous dangerous
onClick={onClickLeaveThread} onClick={onClickLeaveThread}
/> />
); );
}, [onClickLeaveThread, threadInfo]); }, [onClickLeaveThread, threadInfo]);
const onClickPromoteSidebarToThread = React.useCallback(
() =>
pushModal(
<SidebarPromoteModal
threadInfo={threadInfo}
onClose={popModal}
onConfirm={onPromoteSidebar}
/>,
),
[pushModal, threadInfo, popModal, onPromoteSidebar],
);
const promoteSidebar = React.useMemo(() => { const promoteSidebar = React.useMemo(() => {
return ( return (
<MenuItem <MenuItem
key="promote" key="promote"
text="Promote Thread" text="Promote Thread"
icon="message-square-lines" icon="message-square-lines"
onClick={onPromoteSidebar} onClick={onClickPromoteSidebarToThread}
/> />
); );
}, [onPromoteSidebar]); }, [onClickPromoteSidebarToThread]);
const menuItems = React.useMemo(() => { const menuItems = React.useMemo(() => {
const notificationsItem = ( const notificationsItem = (
<MenuItem key="notifications" text="Notifications" icon="bell" /> <MenuItem key="notifications" text="Notifications" icon="bell" />
); );
const separator = <hr key="separator" className={css.separator} />; const separator = <hr key="separator" className={css.separator} />;
// TODO: Enable menu items when the modals are implemented // TODO: Enable menu items when the modals are implemented
Show All 33 Lines