Paths

Table of Contentst

Differential D9199

Encrypt all notifications on the keyserver for Android devices
ClosedPublic
Actions

Authored by marcin on Sep 14 2023, 2:32 AM.

Tags

None

Referenced Files

	F3743935: D9199.diff
	Thu, Jan 9, 2:42 PM

	F3734848: D9199.diff
	Thu, Jan 9, 3:53 AM

	Unknown Object (File)
	Sun, Jan 5, 1:50 PM

	Unknown Object (File)
	Mon, Dec 30, 9:30 PM

	Unknown Object (File)
	Mon, Dec 30, 9:30 PM

	Unknown Object (File)
	Mon, Dec 30, 9:30 PM

	Unknown Object (File)
	Mon, Dec 30, 9:29 PM

	Unknown Object (File)
	Sun, Dec 29, 1:23 AM

Subscribers

Details

Reviewers

tomek
bartek
atul

Commits

rCOMMee5ec067c208: Encrypt all notifications on the keyserver for Android devices

Summary

This differential enables collapsible notifications encryption for Android devices which code version supports this feature.

Test Plan

Build Android app.
Send collapsible notifications.
Ensure that they are correctly collapsed.
Open MariaDB shell and execute select * from olm_sessions;. Ensure that the version of the last session is not incrementing with each collapsible notification.
Go to version-utils.js and change FUTURE_CODE_VERSION to 0.
Repeate 2 and 3.
Open MariaDB shell and execute select * from olm_sessions;. Ensure that the version of the last session is incrementing with each collapsible notification.

Diff Detail

Repository

Branch

marcin/eng-4634

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Sep 14 2023, 2:32 AM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 14 2023, 2:32 AM

marcin added a parent revision: D9198: Enable encrypted notifications coalescing on in Androoid native code..Sep 14 2023, 2:33 AM

Harbormaster completed remote builds in B22625: Diff 31122.Sep 14 2023, 2:49 AM

marcin requested review of this revision.Sep 14 2023, 2:49 AM

marcin edited the summary of this revision. (Show Details)Sep 14 2023, 2:49 AM

marcin edited the test plan for this revision. (Show Details)

tomek accepted this revision.Sep 18 2023, 3:41 AM

This revision is now accepted and ready to land.Sep 18 2023, 3:41 AM

Rebase before landing

Harbormaster completed remote builds in B22730: Diff 31268.Sep 19 2023, 9:23 AM

Rebase before landing

Harbormaster completed remote builds in B23000: Diff 31676.Oct 5 2023, 5:08 AM

Closed by commit rCOMMee5ec067c208: Encrypt all notifications on the keyserver for Android devices (authored by marcin). · Explain WhyOct 5 2023, 5:12 AM

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMMee5ec067c208: Encrypt all notifications on the keyserver for Android devices.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

push/

28 lines

1 line

Diff 31676

keyserver/src/push/send.js

Loading...

keyserver/src/push/types.js

Loading...