[native][web] Convert account deletion components to hooks
ClosedPublic
Actions

Authored by ashoat on Oct 9 2023, 7:08 AM.

Tags

None

Referenced Files

	F3383451: D9426.id31816.diff
	Thu, Nov 28, 3:43 PM

	F3383354: D9426.id31804.diff
	Thu, Nov 28, 2:59 PM

	Unknown Object (File)
	Sun, Nov 24, 9:00 PM

	Unknown Object (File)
	Wed, Nov 6, 1:34 AM

	Unknown Object (File)
	Wed, Nov 6, 1:27 AM

	Unknown Object (File)
	Tue, Nov 5, 11:31 PM

	Unknown Object (File)
	Fri, Nov 1, 8:56 AM

	Unknown Object (File)
	Oct 23 2024, 11:36 AM

View All 60 Files

Subscribers

tomek

will

Details

Reviewers

varun
atul
ginsu

Commits

rCOMMe8593f27916e: [native][web] Convert account deletion components to hooks

Summary

While I was refactoring these, I figured they made more sense as function components.

Depends on D9425

Test Plan

Test account deletion components and make sure they still work

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Oct 9 2023, 7:08 AM

Herald added subscribers: will, tomek. · View Herald TranscriptOct 9 2023, 7:08 AM

Appears to be some miscommunication between Buildkite and Harbormaster. The iOS build appears to have succeeded in Buildkite, but Harbormaster hasn't gotten the message (yet?)

ginsu accepted this revision.Oct 9 2023, 9:39 AM

This revision is now accepted and ready to land.Oct 9 2023, 9:39 AM

This revision was landed with ongoing or failed builds.Oct 9 2023, 9:49 AM

Closed by commit rCOMMe8593f27916e: [native][web] Convert account deletion components to hooks (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMe8593f27916e: [native][web] Convert account deletion components to hooks.

Revision Contents
Changeset List

Path

Size

native/

profile/

delete-account.react.js

136 lines

web/

settings/

account-delete-modal.react.js

116 lines

Diff 31816

View Options

native/profile/delete-account.react.js