[lib] Disable chat mentioning
ClosedPublic
Actions

Authored by tomek on Oct 11 2023, 3:59 AM.

Details

Reviewers

kamil
inka
atul
ashoat

Commits

rCOMM2a40ae7bdba7: [lib] Disable chat mentioning

Summary

A temporary solution to a performance issue that simply disables chat mentioning by returning an empty index.

https://linear.app/comm/issue/ENG-5224/ashoats-js-thread-freezes-on-app-start-on-build-268

Test Plan

Check if chats don't appear in the tooltip.

Diff Detail

Repository

rCOMM Comm

Branch

master6

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Oct 11 2023, 3:59 AM

Herald added a subscriber: will. · View Herald TranscriptOct 11 2023, 3:59 AM

Harbormaster completed remote builds in B23180: Diff 31924.Oct 11 2023, 4:17 AM

tomek requested review of this revision.Oct 11 2023, 4:17 AM

Disable chat mentioning

Harbormaster completed remote builds in B23189: Diff 31933.Oct 11 2023, 7:39 AM

This fixes my perf issues!

This revision is now accepted and ready to land.Oct 11 2023, 8:40 AM

Closed by commit rCOMM2a40ae7bdba7: [lib] Disable chat mentioning (authored by tomek). · Explain WhyOct 11 2023, 8:48 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM2a40ae7bdba7: [lib] Disable chat mentioning.

tomek added a reverting change: D9465: Revert "[lib] Disable chat mentioning".Oct 12 2023, 7:11 AM

tomek added a reverting change: rCOMM0fe842367d0d: Revert "[lib] Disable chat mentioning".Oct 19 2023, 5:09 AM

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

15 lines

Diff 31924

View Options

lib/shared/thread-utils.js

[lib] Disable chat mentioningClosedPublicActions