Page MenuHomePhabricator
Differential D9418

[lib] Migrate the reports and update store type
ClosedPublic
Actions

Authored by tomek on Oct 9 2023, 6:41 AM.
Tags
None
Referenced Files
F3283639: D9418.id32033.diff
Sat, Nov 16, 11:46 AM
Unknown Object (File)
Fri, Nov 1, 5:26 AM
Unknown Object (File)
Oct 2 2024, 9:03 AM
Unknown Object (File)
Oct 2 2024, 9:03 AM
Unknown Object (File)
Oct 2 2024, 9:03 AM
Unknown Object (File)
Oct 2 2024, 8:55 AM
Unknown Object (File)
Oct 2 2024, 6:02 AM
Unknown Object (File)
Sep 14 2024, 8:55 PM
View All 58 Files
Subscribers
ashoat
will

Details

Reviewers
kamil
bartek
inka
Commits
rCOMMca3b9bf9df85: [lib] Migrate the reports and update store type
Summary

Move the reports from user store to report store.

Depends on D9417

https://linear.app/comm/issue/ENG-5162/start-sending-user-inconsistency-reports-to-the-server

Test Plan

Check if teh reports are moved on native. Also, verify that web clients still work.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Oct 9 2023, 6:41 AM
Herald added subscribers: will, ashoat. · View Herald TranscriptOct 9 2023, 6:41 AM
Harbormaster completed remote builds in B23093: Diff 31795.Oct 9 2023, 6:59 AM
tomek requested review of this revision.Oct 9 2023, 6:59 AM
bartek accepted this revision.Oct 11 2023, 11:12 PM
This revision is now accepted and ready to land.Oct 11 2023, 11:12 PM
tomek updated this revision to Diff 32033.Oct 16 2023, 3:12 AM

Handle an edge case when someone had a fresh store with the most recent code version and run a migration (userStore.inconsistencyReports wouldn't be present)

Harbormaster completed remote builds in B23260: Diff 32033.Oct 16 2023, 3:30 AM
Closed by commit rCOMMca3b9bf9df85: [lib] Migrate the reports and update store type (authored by tomek). · Explain WhyOct 16 2023, 5:38 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMMca3b9bf9df85: [lib] Migrate the reports and update store type.

Revision Contents
Changeset List

PathSize
lib/
reducers/
3 lines
types/
2 lines
native/
redux/
1 line
34 lines
web/
redux/
1 line
2 lines

Diff 32038

View Options

lib/reducers/user-reducer.js

Loading...
View Options

lib/types/user-types.js

Loading...
View Options

native/redux/default-state.js

Loading...
View Options

native/redux/persist.js

Loading...
View Options

web/redux/default-state.js

Loading...
View Options

web/redux/redux-setup.js

Loading...