Page MenuHomePhabricator
Differential D9545

[web] Fix thread creation from media
ClosedPublic
Actions

Authored by ashoat on Oct 19 2023, 1:15 PM.
Tags
None
Referenced Files
F3398110: D9545.diff
Sun, Dec 1, 9:03 PM
Unknown Object (File)
Fri, Nov 29, 8:41 PM
Unknown Object (File)
Mon, Nov 25, 7:02 PM
Unknown Object (File)
Sat, Nov 23, 2:08 PM
Unknown Object (File)
Tue, Nov 19, 8:15 PM
Unknown Object (File)
Fri, Nov 8, 1:27 AM
Unknown Object (File)
Fri, Nov 8, 1:26 AM
Unknown Object (File)
Fri, Nov 8, 1:23 AM
View All 89 Files
Subscribers
will

Details

Reviewers
bartek
atul
tomek
Commits
rCOMMea70657bd6b7: [web] Fix thread creation from media
Summary

This solves ENG-5145, a regression introduced in D7434.

The issue is that pending threads don't appear in the ThreadStore. Instead of trying to pull the ThreadInfo from the ThreadStore, we should drill it through from the callsites.

Test Plan

I confirmed that I'm again able to create a thread from media in my local environment (the bug no longer repros)

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/webthreadfrommedia
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

Diff 32231

View Options

web/chat/chat-input-bar.react.js

Loading...
View Options

web/chat/chat-message-list-container.react.js

Loading...
View Options

web/input/input-state-container.react.js

Loading...
View Options

web/input/input-state.js

Loading...