Differential D9555

[native] implement deleteUser native client method and expose it via CommRustModule
ClosedPublic
Actions

Authored by varun on Oct 20 2023, 9:00 AM.

Tags

None

Referenced Files

	F3398438: D9555.id32268.diff
	Sun, Dec 1, 11:01 PM

	F3397841: D9555.diff
	Sun, Dec 1, 7:41 PM

	Unknown Object (File)
	Sat, Nov 30, 1:07 AM

	Unknown Object (File)
	Wed, Nov 20, 4:38 PM

	Unknown Object (File)
	Wed, Nov 20, 4:38 PM

	Unknown Object (File)
	Wed, Nov 20, 4:37 PM

	Unknown Object (File)
	Wed, Nov 20, 4:18 PM

	Unknown Object (File)
	Tue, Nov 12, 3:08 PM

View All 61 Files

Subscribers

Details

Reviewers

bartek
kamil

Commits

rCOMM3b72f4b0a1be: [native] implement deleteUser native client method and expose it via…

Summary

this is pretty similar to the updatePassword method. we just send the standard auth info (access token, user ID, device ID). since it's available in the comm secure store now, so we can probably refactor the JSI function in the future to not take any params. for now, though, i'm just following the pattern in updatePassword.

Test Plan

registered a new user and then called deleteUser from js and verified that the user's data was removed from my local ddb tables

Diff Detail

Repository

Branch

new-master (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Oct 20 2023, 9:00 AM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 20 2023, 9:00 AM

Harbormaster completed remote builds in B23403: Diff 32268.Oct 20 2023, 9:18 AM

varun requested review of this revision.Oct 20 2023, 9:18 AM

native/native_rust_library/src/lib.rs
593	Could you remind me - is this hardcoded address going to be replaced once we have the getCommConfig stuff implemented?

This revision is now accepted and ready to land.Oct 20 2023, 9:36 AM

varun added inline comments.Oct 20 2023, 9:49 AM

native/native_rust_library/src/lib.rs
593	yeah that's correct. this is tracked in ENG-4885

Closed by commit rCOMM3b72f4b0a1be: [native] implement deleteUser native client method and expose it via… (authored by varun). · Explain WhyOct 20 2023, 9:49 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM3b72f4b0a1be: [native] implement deleteUser native client method and expose it via….

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommRustModule.h

5 lines

CommRustModule.cpp

24 lines

_generated/

rustJSI-generated.cpp

native_rust_library/

src/

45 lines

schema/

CommRustModuleSchema.js

5 lines

Diff 32268

native/cpp/CommonCpp/NativeModules/CommRustModule.h

Loading...

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp

Loading...

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

Loading...

native/cpp/CommonCpp/_generated/rustJSI.h

Loading...

native/native_rust_library/src/lib.rs

Loading...

native/schema/CommRustModuleSchema.js

Loading...