Revert "Revert "Implement stateful and deferrable notification decryption and use it on iOS in NSE""
ClosedPublic
Actions

Authored by ashoat on Oct 22 2023, 4:04 PM.

Details

Reviewers

marcin
tomek
bartek
atul

Commits

rCOMM8a79b69fbd94: Revert "Revert "Implement stateful and deferrable notification decryption and…

Summary

This reverts commit 56c0498aa0a3c415243be9097eedd673a6dc38c1.

Depends on D9559

Test Plan

This is bringing back @marcin's D9401. Changes to fix the resulting bug (ENG-5354) will follow in subsequent diffs.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Oct 22 2023, 4:04 PM

Herald added a subscriber: will. · View Herald TranscriptOct 22 2023, 4:04 PM

ashoat added a child revision: D9561: [native] Avoid copy-constructing CryptoModule.Oct 22 2023, 4:05 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 22 2023, 4:06 PM

Harbormaster failed remote builds in B23415: Diff 32296!

Rebase

Harbormaster completed remote builds in B23419: Diff 32300.Oct 22 2023, 4:32 PM

ashoat requested review of this revision.Oct 22 2023, 4:32 PM

This is bringing back @marcin's D9401. Changes to fix the resulting bug (ENG-5354) will follow in subsequent diffs.

Perhaps, we could reorder diffs to comply to the convention that diffs should't leave the code in broken state even if they won't be landed independently.

This revision is now accepted and ready to land.Oct 23 2023, 9:20 AM

I see your point – I'll try to do that next time. In this case, since I'm landing these together as a stack I'm going to skip the extra work of reordering

Closed by commit rCOMM8a79b69fbd94: Revert "Revert "Implement stateful and deferrable notification decryption and…. · Explain WhyOct 23 2023, 12:13 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM8a79b69fbd94: Revert "Revert "Implement stateful and deferrable notification decryption and….

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

Notifications/

BackgroundDataStorage/

NotificationsCryptoModule.h

19 lines

NotificationsCryptoModule.cpp

59 lines

ios/

NotificationService/

NotificationService.mm

36 lines

Diff 32300

View Options

native/cpp/CommonCpp/Notifications/BackgroundDataStorage/NotificationsCryptoModule.h

View Options

native/cpp/CommonCpp/Notifications/BackgroundDataStorage/NotificationsCryptoModule.cpp

View Options

native/ios/NotificationService/NotificationService.mm

Revert "Revert "Implement stateful and deferrable notification decryption and use it on iOS in NSE""ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 32300

native/cpp/CommonCpp/Notifications/BackgroundDataStorage/NotificationsCryptoModule.h

native/cpp/CommonCpp/Notifications/BackgroundDataStorage/NotificationsCryptoModule.cpp

native/ios/NotificationService/NotificationService.mm

Revert "Revert "Implement stateful and deferrable notification decryption and use it on iOS in NSE""
ClosedPublic
Actions

Revision Contents
Changeset List