Page MenuHomePhabricator
Differential D9612

[native][web] remove unused device ID code
ClosedPublic
Actions

Authored by varun on Oct 26 2023, 10:26 AM.
Tags
None
Referenced Files
F3400528: D9612.id32505.diff
Mon, Dec 2, 7:36 AM
F3400499: D9612.id32435.diff
Mon, Dec 2, 7:28 AM
F3399954: D9612.diff
Mon, Dec 2, 5:27 AM
Unknown Object (File)
Wed, Nov 20, 10:57 PM
Unknown Object (File)
Tue, Nov 12, 11:21 PM
Unknown Object (File)
Tue, Nov 12, 9:21 PM
Unknown Object (File)
Tue, Nov 12, 9:04 PM
Unknown Object (File)
Tue, Nov 12, 6:40 PM
View All 54 Files
Subscribers
ashoat
inka
tomek
will

Details

Reviewers
kamil
inka
Commits
rCOMM7ee568fe0dad: [native][web] remove unused device ID code
Summary

this is a follow up (depends on D9556). we don't need any of this device ID code now that we're just using the content ed25519 public key as the device ID.

Test Plan

successfully built and ran native and web

Diff Detail

Repository
rCOMM Comm
Branch
new-master (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Oct 26 2023, 10:26 AM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 26 2023, 10:26 AM
Harbormaster completed remote builds in B23517: Diff 32435.Oct 26 2023, 10:44 AM
varun requested review of this revision.Oct 26 2023, 10:44 AM
kamil accepted this revision.Oct 27 2023, 6:13 AM
kamil added a reviewer: inka.
kamil added a subscriber: inka.

LGTM, @inka as this was code introduced by you, could you take a look?

inka accepted this revision.Oct 30 2023, 7:54 AM
This revision is now accepted and ready to land.Oct 30 2023, 7:54 AM
Closed by commit rCOMM7ee568fe0dad: [native][web] remove unused device ID code (authored by varun). · Explain WhyOct 30 2023, 9:57 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM7ee568fe0dad: [native][web] remove unused device ID code.

Revision Contents
Changeset List

Diff 32435

View Options

native/native_rust_library/src/crypto_tools.rs

Loading...
View Options

native/native_rust_library/src/lib.rs

Loading...
View Options

web/app.react.js

Loading...
View Options

web/redux/action-types.js

Loading...
View Options

web/redux/default-state.js

Loading...
View Options

web/redux/device-id-reducer.js

Loading...
View Options

web/redux/device-id-updater.js

Loading...
View Options

web/redux/persist.js

Loading...
View Options

web/redux/redux-setup.js

Loading...
View Options

web/utils/device-id.js

Loading...
View Options

web/utils/device-id.test.js

Loading...
View Options

web/utils/text-utils.js

Loading...
View Options

web/utils/text-utils.test.js

Loading...