Introduce rolePermissionToBitmaskHex which turns threadRolePermission string into hex-encoded bitmask.
Context: https://linear.app/comm/issue/ENG-5388/encodepermissions-for-rolepermissionsblob
Details
Details
Unit tests, more testing in upcoming diff which handles decoding back to rolePermissionString
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- arcpatch-D9662 (branched from master)
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/permissions/minimally-encoded-thread-permissions.js | ||
|---|---|---|
| 74–79 ↗ | (On Diff #32570) | This took me a bit of thinking to really understand. I wonder if it would be better to reverse the relationship between minimallyEncodedThreadPermissions and baseRolePermissionEncoding. What if you started by defining baseRolePermissionEncoding using Object.freeze, and then created minimallyEncodedThreadPermissions from that? |
| lib/permissions/minimally-encoded-thread-permissions.js | ||
|---|---|---|
| 74–79 ↗ | (On Diff #32570) | It does make sense to have the "starting" Object be "simple" (just BigInt(idx)) and then generate the more "complex" one "programmatically" from it. Will update this diff (and also add some comments to give future readers a bit more clarity). |
| lib/permissions/minimally-encoded-thread-permissions.js | ||
|---|---|---|
| 12–18 ↗ | (On Diff #32606) | (FYI had ChatGPT rewrite these comments for me, which is why they sound the way they do) |