Paths

Table of Contentst

-
lib/utils/
-
utils/
-
objects.js
-
objects.test.js

[lib] Add some unit tests for `invertObjectToMap<K, V>(obj: { [K]: V })`
ClosedPublic
Actions

Authored by atul on Nov 2 2023, 11:57 AM.

Details

Reviewers

ashoat
ginsu
tomek
rohan

Commits

rCOMM0eb7a828a7d8: [lib] Add some unit tests for `invertObjectToMap<K, V>(obj: { [K]: V })`

Summary

Generated some basic unit tests for invertObjectToMap via GitHub Copilot.

One of the generated tests failed and surfaced possiblity that object entries could be "lost" if there were duplicate values... which is very often a possiblity. Added invariant to ensure values are unique and no entries are lost. Should be O(1) check so not worried about overhead.

Test Plan

Unit tests pass, made sure we had a test for BigInt values.

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D9677 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Nov 2 2023, 11:57 AM

Herald added a subscriber: will. · View Herald TranscriptNov 2 2023, 11:57 AM

atul published this revision for review.Nov 2 2023, 12:16 PM

Harbormaster completed remote builds in B23687: Diff 32641.Nov 2 2023, 12:24 PM

Sure

This revision is now accepted and ready to land.Nov 2 2023, 12:50 PM

rebase before landing

This revision was landed with ongoing or failed builds.Nov 2 2023, 6:21 PM

Closed by commit rCOMM0eb7a828a7d8: [lib] Add some unit tests for `invertObjectToMap<K, V>(obj: { [K]: V })` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM0eb7a828a7d8: [lib] Add some unit tests for `invertObjectToMap<K, V>(obj: { [K]: V })`.

Harbormaster completed remote builds in B23697: Diff 32654.Nov 2 2023, 6:32 PM

Revision Contents
Changeset List

Path

Size

lib/

utils/

objects.js

4 lines

objects.test.js

54 lines

Diff 32654

View Options

lib/utils/objects.js

	Show First 20 Lines • Show All 74 Lines • ▼ Show 20 Lines
	}			}
	div.main-header > h1 {			div.main-header > h1 {
	color: var(--fg);			color: var(--fg);
	padding-left: 92px;			padding-left: 92px;
	font-family: var(--font-logo);			font-family: var(--font-logo);
	line-height: var(--line-height-text);			line-height: var(--line-height-text);
	font-weight: var(--semi-bold);			font-weight: var(--semi-bold);
	font-size: var(--logo-font-22);			font-size: var(--logo-font-22);
				cursor: pointer;
	}			}

	div.main-content-container {			div.main-content-container {
	position: relative;			position: relative;
	grid-area: app;			grid-area: app;
	}			}
	div.main-content {			div.main-content {
	height: 100%;			height: 100%;
	▲ Show 20 Lines • Show All 189 Lines • Show Last 20 Lines