Page MenuHomePhabricator
Differential D9677

[lib] Add some unit tests for `invertObjectToMap<K, V>(obj: { [K]: V })`
ClosedPublic
Actions

Authored by atul on Nov 2 2023, 11:57 AM.
Tags
None
Referenced Files
F3553737: D9677.diff
Thu, Dec 26, 9:04 PM
Unknown Object (File)
Fri, Dec 20, 12:28 AM
Unknown Object (File)
Sat, Nov 30, 6:53 PM
Unknown Object (File)
Sat, Nov 30, 11:49 AM
Unknown Object (File)
Nov 16 2024, 8:54 PM
Unknown Object (File)
Nov 16 2024, 8:54 PM
Unknown Object (File)
Nov 16 2024, 8:54 PM
Unknown Object (File)
Nov 16 2024, 8:54 PM
View All 72 Files
Subscribers
will

Details

Reviewers
ashoat
ginsu
tomek
rohan
Commits
rCOMM0eb7a828a7d8: [lib] Add some unit tests for `invertObjectToMap<K, V>(obj: { [K]: V })`
Summary

Generated some basic unit tests for invertObjectToMap via GitHub Copilot.

One of the generated tests failed and surfaced possiblity that object entries could be "lost" if there were duplicate values... which is very often a possiblity. Added invariant to ensure values are unique and no entries are lost. Should be O(1) check so not worried about overhead.

Test Plan

Unit tests pass, made sure we had a test for BigInt values.

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D9677 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
utils/
4 lines
54 lines

Diff 32654

View Options

lib/utils/objects.js

Loading...
View Options

lib/utils/objects.test.js

Loading...