Page MenuHomePhabricator
Differential D9683

[native] stop persisting `messageStore.threads` via redux-persist
ClosedPublic
Actions

Authored by kamil on Nov 3 2023, 6:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 31, 6:31 AM
Unknown Object (File)
Tue, Dec 31, 6:31 AM
Unknown Object (File)
Tue, Dec 31, 6:31 AM
Unknown Object (File)
Tue, Dec 31, 6:31 AM
Unknown Object (File)
Tue, Dec 31, 6:30 AM
Unknown Object (File)
Tue, Dec 31, 6:22 AM
Unknown Object (File)
Tue, Dec 10, 3:12 AM
Unknown Object (File)
Nov 30 2024, 2:43 PM
View All 95 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
atul
Commits
rCOMM84c5f15e4a68: [native] stop persisting `messageStore.threads` via redux-persist
Summary

ENG-3743

We have this data in SQLite now.

Depends on D9682

Test Plan

Try closing and opening the app multiple times to make sure there are no weird errors.

Diff Detail

Repository
rCOMM Comm
Branch
stop-persist-msg
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Nov 3 2023, 6:49 AM
kamil held this revision as a draft.
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptNov 3 2023, 6:49 AM
kamil published this revision for review.Nov 3 2023, 7:00 AM
Harbormaster completed remote builds in B23715: Diff 32674.Nov 3 2023, 7:10 AM
atul accepted this revision.Nov 3 2023, 11:33 AM
atul added inline comments.
native/redux/persist.js
989

Is your editor auto formatter maybe adding these newlines? Feel free to disregard if intentional, but noticed these D9682 as well.

This revision is now accepted and ready to land.Nov 3 2023, 11:33 AM
kamil added inline comments.Nov 6 2023, 9:22 AM
native/redux/persist.js
989

looks like it's my IDE fault, it is adding this while committing, I'll take a look

kamil updated this revision to Diff 32895.Nov 7 2023, 7:14 AM

remove blank lines

kamil updated this revision to Diff 32897.Nov 7 2023, 7:22 AM

rebase

atul added inline comments.Nov 7 2023, 9:14 AM
native/redux/persist.js
989

Sweet, thanks for taking a look!

Not a huge deal regardless, guess it clutters up git blame history a bit.. but not end of the world

This revision was landed with ongoing or failed builds.Nov 8 2023, 3:42 AM
Closed by commit rCOMM84c5f15e4a68: [native] stop persisting `messageStore.threads` via redux-persist (authored by kamil). · Explain Why
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM84c5f15e4a68: [native] stop persisting `messageStore.threads` via redux-persist.
Harbormaster completed remote builds in B23867: Diff 32895.Nov 8 2023, 6:50 AM
Harbormaster completed remote builds in B23869: Diff 32897.Nov 8 2023, 6:54 AM

Revision Contents
Changeset List

PathSize
native/
redux/
28 lines

Diff 32674

View Options

native/redux/persist.js

Loading...