Page MenuHomePhabricator
Differential D9824

Reset badgeCount during log out
ClosedPublic
Actions

Authored by marcin on Nov 10 2023, 9:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 16, 2:32 PM
Unknown Object (File)
Wed, Apr 16, 8:48 AM
Unknown Object (File)
Wed, Apr 16, 12:59 AM
Unknown Object (File)
Tue, Apr 15, 10:42 PM
Unknown Object (File)
Tue, Apr 15, 7:41 PM
Unknown Object (File)
Tue, Apr 15, 6:00 AM
Unknown Object (File)
Sat, Apr 12, 5:39 PM
Unknown Object (File)
Wed, Apr 9, 6:46 AM
View All Files
Subscribers
ashoat
tomek
will

Details

Reviewers
tomek
atul
Commits
rCOMM5ca72bdf9779: Reset badgeCount during log out
Summary

This differential fixes badge count behaviour during log-out. The context is here:
https://linear.app/comm/issue/ENG-5169/badge-count-is-not-reset-when-logging-out.

Test Plan

Before this diff:

  1. Update badge count of app (mark some threads as unread on web)
  2. Log out
  3. Ensure badge count remains unchanged.

After this diff:

  1. Update badge count of app (mark some threads as unread on web)
  2. Log out
  3. Ensure badge count is cleared.

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-5169
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Nov 10 2023, 9:14 AM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptNov 10 2023, 9:14 AM
marcin added reviewers: tomek, atul.Nov 10 2023, 9:15 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Nov 10 2023, 9:31 AM
Harbormaster failed remote builds in B24000: Diff 33074!
marcin updated this revision to Diff 33110.Nov 13 2023, 2:21 AM

Fix invalid Android method name

Harbormaster completed remote builds in B24027: Diff 33110.Nov 13 2023, 2:41 AM
marcin requested review of this revision.Nov 13 2023, 2:41 AM
atul accepted this revision.Nov 13 2023, 9:26 AM
This revision is now accepted and ready to land.Nov 13 2023, 9:26 AM
marcin updated this revision to Diff 33130.Nov 13 2023, 9:43 AM

Rebase before landing

Harbormaster completed remote builds in B24044: Diff 33130.Nov 13 2023, 10:06 AM
Closed by commit rCOMM5ca72bdf9779: Reset badgeCount during log out (authored by marcin). · Explain WhyNov 13 2023, 10:08 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM5ca72bdf9779: Reset badgeCount during log out.

Revision Contents
Changeset List

PathSize
native/
push/
9 lines

Diff 33074

View Options

native/push/push-handler.react.js

package app.comm.android; package app.comm.android;
import android.content.Context; import android.content.Context;
import android.content.res.Configuration; import android.content.res.Configuration;
import android.database.CursorWindow; import android.database.CursorWindow;
import androidx.annotation.NonNull; import androidx.annotation.NonNull;
import androidx.multidex.MultiDexApplication; import androidx.multidex.MultiDexApplication;
import app.comm.android.commservices.CommServicesPackage; import app.comm.android.commservices.CommServicesPackage;
import app.comm.android.fbjni.CommMMKV;
import app.comm.android.fbjni.CommSecureStore; import app.comm.android.fbjni.CommSecureStore;
import app.comm.android.fbjni.DatabaseInitializer; import app.comm.android.fbjni.DatabaseInitializer;
import app.comm.android.fbjni.GlobalDBSingleton; import app.comm.android.fbjni.GlobalDBSingleton;
import app.comm.android.newarchitecture.MainApplicationReactNativeHost; import app.comm.android.newarchitecture.MainApplicationReactNativeHost;
import app.comm.android.notifications.CommAndroidNotificationsPackage; import app.comm.android.notifications.CommAndroidNotificationsPackage;
import com.facebook.react.PackageList; import com.facebook.react.PackageList;
import com.facebook.react.ReactApplication; import com.facebook.react.ReactApplication;
import com.facebook.react.ReactInstanceManager; import com.facebook.react.ReactInstanceManager;
▲ Show 20 Lines • Show All 69 Lines • ▼ Show 20 Lines public void onCreate() {
// system // system
MainApplication.context = this.getApplicationContext(); MainApplication.context = this.getApplicationContext();
ReactFeatureFlags.useTurboModules = BuildConfig.IS_NEW_ARCHITECTURE_ENABLED; ReactFeatureFlags.useTurboModules = BuildConfig.IS_NEW_ARCHITECTURE_ENABLED;
Security.insertProviderAt(new org.conscrypt.OpenSSLProvider(), 1); Security.insertProviderAt(new org.conscrypt.OpenSSLProvider(), 1);
SoLoader.init(this, /* native exopackage */ false); SoLoader.init(this, /* native exopackage */ false);
this.initializeDatabase(); this.initializeDatabase();
CommMMKV.initialize();
ApplicationLifecycleDispatcher.onApplicationCreate(this); ApplicationLifecycleDispatcher.onApplicationCreate(this);
try { try {
Field field = CursorWindow.class.getDeclaredField("sCursorWindowSize"); Field field = CursorWindow.class.getDeclaredField("sCursorWindowSize");
field.setAccessible(true); field.setAccessible(true);
field.set(null, 100 * 1024 * 1024); // 100 MiB field.set(null, 100 * 1024 * 1024); // 100 MiB
} catch (Exception e) { } catch (Exception e) {
if (BuildConfig.DEBUG) { if (BuildConfig.DEBUG) {
e.printStackTrace(); e.printStackTrace();
Show All 25 Lines