Page MenuHomePhabricator
Differential D9845

[lib] Update `threadHasPermission` to "go through" `permissionLookup`
ClosedPublic
Actions

Authored by atul on Nov 13 2023, 1:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 28, 5:54 PM
Unknown Object (File)
Sat, Dec 28, 5:54 PM
Unknown Object (File)
Sat, Dec 28, 5:53 PM
Unknown Object (File)
Sat, Dec 28, 5:42 PM
Unknown Object (File)
Thu, Dec 26, 12:38 AM
Unknown Object (File)
Mon, Dec 23, 5:59 AM
Unknown Object (File)
Wed, Dec 18, 1:50 PM
Unknown Object (File)
Dec 5 2024, 12:08 AM
View All 56 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
rohan
tomek
Commits
rCOMM561705347d2c: [lib] Update `threadHasPermission` to "go through" `permissionLookup`
Summary

Update threadHasPermission to "go through" permissionLookup for checking permissions rather than indexing into threadInfo.currentUser.permission directly.
This ensures that behavior of threadHasPermission matches permissionLookup. Specifically, to ensure that the KNOW_OF permission is also true in addition to whatever permission is being checked. This will also ensure that in the future we only need to add conditions in "one place."

Depends on D9844

Test Plan

Close reading/flow, don't think we need a unit test for this...

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Nov 13 2023, 1:03 PM
atul published this revision for review.Nov 13 2023, 1:04 PM
atul added inline comments.
lib/shared/thread-utils.js
135–137

This case is handled within permissionLookup so removing duplicate logic (even though I guess it would "short circuit" a function call).

atul mentioned this in D9841: [lib] Update `threadMemberHasPermission` to support `MinimallyEncodedRawThreadInfo`.Nov 13 2023, 1:04 PM
atul added a child revision: D9846: [lib] Introduce `MinimallyEncodedThreadInfo` type.Nov 13 2023, 1:25 PM
Harbormaster completed remote builds in B24057: Diff 33147.Nov 13 2023, 1:28 PM
ashoat accepted this revision.Nov 13 2023, 2:00 PM

Thanks for identifying / fixing this

This revision is now accepted and ready to land.Nov 13 2023, 2:00 PM
Closed by commit rCOMM561705347d2c: [lib] Update `threadHasPermission` to "go through" `permissionLookup` (authored by atul). · Explain WhyNov 13 2023, 2:20 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM561705347d2c: [lib] Update `threadHasPermission` to "go through" `permissionLookup`.

Revision Contents
Changeset List

PathSize
lib/
shared/
4 lines

Diff 33147

View Options

lib/shared/thread-utils.js

Loading...