[lib] Update `threadUIName` to handle `MinimallyEncodedThreadInfo`
ClosedPublic
Actions

Authored by atul on Nov 13 2023, 2:29 PM.

Details

Reviewers

ashoat
ginsu
tomek
rohan

Commits

rCOMM49eb8d9b7709: [lib] Update `threadUIName` to handle `MinimallyEncodedThreadInfo`

Summary

Just needed to add some branching to appease flow.

Depends on D9847

Test Plan

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Nov 13 2023, 2:29 PM

Harbormaster completed remote builds in B24061: Diff 33159.Nov 13 2023, 2:48 PM

atul requested review of this revision.Nov 13 2023, 2:48 PM

atul added a child revision: D9856: [lib] Move `MinimallyEncoded*` validators to their own file.Nov 13 2023, 2:59 PM

Please add types before landing

lib/shared/thread-utils.js
945–946 ↗	(On Diff #33159)	Can you add types to these? The new version of Flow won't like this

ashoat accepted this revision.Nov 14 2023, 6:24 AM

This revision is now accepted and ready to land.Nov 14 2023, 6:24 AM

address feedback (type annotations)

This revision was landed with ongoing or failed builds.Nov 14 2023, 11:55 AM

Closed by commit rCOMM49eb8d9b7709: [lib] Update `threadUIName` to handle `MinimallyEncodedThreadInfo` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM49eb8d9b7709: [lib] Update `threadUIName` to handle `MinimallyEncodedThreadInfo`.

Harbormaster completed remote builds in B24120: Diff 33220.Nov 14 2023, 12:09 PM

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

25 lines

utils/

entity-text.js

2 lines

Diff 33220

View Options

lib/shared/thread-utils.js