Paths

Table of Contentst

[lib] Update `checkIfDefaultMembersAreVoiced` to handle `MinimallyEncodedThreadInfo`
ClosedPublic
Actions

Authored by atul on Nov 14 2023, 3:26 PM.

Tags

None

Referenced Files

	F3299914: D9889.id33255.diff
	Sun, Nov 17, 4:24 PM

	F3299609: D9889.diff
	Sun, Nov 17, 2:13 PM

	Unknown Object (File)
	Fri, Nov 8, 10:05 PM

	Unknown Object (File)
	Fri, Nov 8, 10:05 PM

	Unknown Object (File)
	Fri, Nov 8, 10:05 PM

	Unknown Object (File)
	Fri, Nov 8, 10:02 PM

	Unknown Object (File)
	Tue, Nov 5, 2:13 AM

	Unknown Object (File)
	Oct 2 2024, 1:29 PM

View All 67 Files

Subscribers

None

Details

Reviewers

ashoat
ginsu
tomek
rohan

Commits

rCOMM591adc4aed97: [lib] Update `checkIfDefaultMembersAreVoiced` to handle…

Summary

IF RoleInfo is minimallyEncoded, decode the permissions and then proceed with truthiness check.

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Nov 14 2023, 3:26 PM

atul published this revision for review.Nov 14 2023, 3:27 PM

Harbormaster completed remote builds in B24130: Diff 33233.Nov 14 2023, 3:46 PM

ashoat accepted this revision.Nov 14 2023, 5:13 PM

This revision is now accepted and ready to land.Nov 14 2023, 5:13 PM

atul added a child revision: D9890: [lib] Update misc parts of `lib` to support `MinimallyEncodedThreadInfo`.Nov 14 2023, 5:43 PM

land

This revision was landed with ongoing or failed builds.Nov 15 2023, 5:10 AM

Closed by commit rCOMM591adc4aed97: [lib] Update `checkIfDefaultMembersAreVoiced` to handle… (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM591adc4aed97: [lib] Update `checkIfDefaultMembersAreVoiced` to handle….

Harbormaster completed remote builds in B24144: Diff 33255.Nov 15 2023, 5:37 AM

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

11 lines

Diff 33256

View Options

lib/shared/thread-utils.js

[lib] Update `checkIfDefaultMembersAreVoiced` to handle `MinimallyEncodedThreadInfo`ClosedPublicActions