Page MenuHomePhabricator
Differential D9906

[native] save the recently deleted server url to customServer redux state
ClosedPublic
Actions

Authored by ginsu on Nov 15 2023, 1:36 PM.
Tags
None
Referenced Files
F3241559: D9906.id34192.diff
Wed, Nov 13, 7:19 PM
F3241551: D9906.id33303.diff
Wed, Nov 13, 7:13 PM
Unknown Object (File)
Tue, Nov 12, 12:06 PM
Unknown Object (File)
Sat, Nov 9, 2:42 AM
Unknown Object (File)
Sat, Nov 9, 2:41 AM
Unknown Object (File)
Sat, Nov 9, 2:38 AM
Unknown Object (File)
Sat, Nov 9, 2:32 AM
Unknown Object (File)
Sat, Nov 9, 2:31 AM
View All 78 Files
Subscribers
ashoat
tomek

Details

Reviewers
inka
rohan
michal
Commits
rCOMMdf29fd4b968e: [native] save the recently deleted server url to customServer redux state
Summary

As I was organizing my Linear tasks, I realized that there was a piece of behavior with the remove keyserver user experience that I did not implement

  • if a server is removed from the list, and the user is staff or in dev mode, we want this url to be saved to customServer
  • if a user is staff or in dev mode, we want the input field to be pre-populated with value from customServer

This diff implements the functionality described above

Part of linear task: https://linear.app/comm/issue/ENG-4718/add-remove-keyserver-button-logic

Test Plan

Please see the demo video below

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Nov 15 2023, 1:36 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 15 2023, 1:36 PM
ginsu edited the summary of this revision. (Show Details)Nov 15 2023, 1:38 PM
ginsu edited the summary of this revision. (Show Details)Nov 15 2023, 1:43 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: inka, rohan, michal.
ginsu attached a referenced file: F880244: Screen Recording 2023-11-15 at 4.41.56 PM.mov. (Show Details)
Harbormaster completed remote builds in B24185: Diff 33303.Nov 15 2023, 4:14 PM
ginsu requested review of this revision.Nov 15 2023, 4:14 PM
inka accepted this revision.Nov 16 2023, 8:49 AM

Nice!

This revision is now accepted and ready to land.Nov 16 2023, 8:49 AM
ginsu updated this revision to Diff 34192.Dec 4 2023, 7:16 AM

rebase before landing

Harbormaster completed remote builds in B24734: Diff 34192.Dec 4 2023, 8:57 AM
ginsu updated this revision to Diff 34250.Dec 4 2023, 10:52 PM

rebase one more time

This revision was landed with ongoing or failed builds.Dec 4 2023, 11:02 PM
Closed by commit rCOMMdf29fd4b968e: [native] save the recently deleted server url to customServer redux state (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMdf29fd4b968e: [native] save the recently deleted server url to customServer redux state.
Harbormaster completed remote builds in B24785: Diff 34250.Dec 4 2023, 11:12 PM

Revision Contents
Changeset List

Diff 33303

View Options

native/profile/add-keyserver.react.js

Loading...
View Options

native/profile/keyserver-selection-bottom-sheet.react.js

Loading...