Page MenuHomePhabricator
Differential D9901

[lib] Rename getRolePermissionBlobsForCommunity to getRolePermissionBlobsForCommunityRoot
ClosedPublic
Actions

Authored by rohan on Nov 15 2023, 12:04 PM.
Tags
None
Referenced Files
F3048522: D9901.id33384.diff
Tue, Oct 22, 11:28 PM
F3048481: D9901.id33286.diff
Tue, Oct 22, 11:20 PM
F3048079: D9901.diff
Tue, Oct 22, 9:37 PM
Unknown Object (File)
Tue, Oct 8, 2:48 PM
Unknown Object (File)
Sat, Sep 28, 6:03 PM
Unknown Object (File)
Sat, Sep 28, 5:27 PM
Unknown Object (File)
Sat, Sep 28, 4:23 PM
Unknown Object (File)
Sep 22 2024, 11:04 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
ginsu
ashoat
Commits
rCOMMd8e045b1de70: [lib] Rename getRolePermissionBlobsForCommunity to…
Summary

Just a small rename since this function is only for community roots

Depends on D9900

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rohan created this revision.Nov 15 2023, 12:04 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 15 2023, 12:04 PM
rohan published this revision for review.Nov 15 2023, 12:26 PM
Harbormaster completed remote builds in B24168: Diff 33286.Nov 15 2023, 1:05 PM
rohan added a child revision: D9804: [lib] Include Voiced permission blob for announcement channels.Nov 17 2023, 7:10 AM
rohan mentioned this in D9897: [lib] Introduce getUniversalCommunityRootPermissionsBlob.Nov 17 2023, 7:26 AM
rohan updated this revision to Diff 33384.Nov 17 2023, 7:37 AM

Rebase

Harbormaster completed remote builds in B24246: Diff 33384.Nov 17 2023, 8:21 AM
rohan added a child revision: D9924: [lib] Use configurableCommunityPermissions in getRolePermissionBlobsForCommunityRoot.Nov 17 2023, 9:02 AM
rohan removed a child revision: D9804: [lib] Include Voiced permission blob for announcement channels.Nov 17 2023, 9:02 AM
rohan edited child revisions, added: D9804: [lib] Include Voiced permission blob for announcement channels; removed: D9924: [lib] Use configurableCommunityPermissions in getRolePermissionBlobsForCommunityRoot.Nov 20 2023, 9:43 AM
rohan updated this revision to Diff 33436.Nov 20 2023, 9:46 AM

Rebase

Harbormaster completed remote builds in B24286: Diff 33436.Nov 20 2023, 10:07 AM
rohan added a child revision: D9827: [keyserver/lib/native] Introduce VOICED_IN_ANNOUNCEMENT_CHANNELS thread permission.Nov 20 2023, 2:55 PM
rohan removed a child revision: D9804: [lib] Include Voiced permission blob for announcement channels.
rohan updated this revision to Diff 33463.Nov 21 2023, 8:39 AM

Rebase

Harbormaster completed remote builds in B24311: Diff 33463.Nov 21 2023, 9:21 AM
ashoat accepted this revision.Nov 22 2023, 6:51 AM
This revision is now accepted and ready to land.Nov 22 2023, 6:51 AM
rohan updated this revision to Diff 33496.Nov 22 2023, 6:58 AM

Rebase

Harbormaster completed remote builds in B24339: Diff 33496.Nov 22 2023, 8:24 AM
Closed by commit rCOMMd8e045b1de70: [lib] Rename getRolePermissionBlobsForCommunity to… (authored by rohan). · Explain WhyNov 22 2023, 8:48 AM
This revision was automatically updated to reflect the committed changes.
rohan added a commit: rCOMMd8e045b1de70: [lib] Rename getRolePermissionBlobsForCommunity to….

Revision Contents
Changeset List

PathSize
lib/
permissions/
4 lines

Diff 33526

View Options

lib/permissions/thread-permissions.js

Loading...