[lib] Include Voiced permission blob for announcement channels
AbandonedPublic
Actions

Authored by rohan on Nov 9 2023, 8:19 AM.

Details

Reviewers

atul
ginsu
ashoat

Summary

For both COMMUNITY_OPEN_ANNOUNCEMENT_SUBTHREAD and COMMUNITY_SECRET_ANNOUNCEMENT_SUBTHREAD, we should include a Voiced permission blob. This should just be a union between the existing thread permissions blob and the voiced permissions blob. This is in an effort to correctly have the 'Voiced in announcement channels' user-surfaced permission allow users to speak in announcement channels.

Will add @ashoat as a reviewer for some diffs here since this is a solution we discussed in our 1:1

Addresses ENG-5634

Depends on D9901

Test Plan

Confirmed that subchannel creation still worked fine, and checked MariaDB to see for COMMUNITY_OPEN_ANNOUNCEMENT_SUBTHREAD and COMMUNITY_SECRET_ANNOUNCEMENT_SUBTHREAD, the Voiced role was also created.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

rohan created this revision.Nov 9 2023, 8:19 AM

Herald added subscribers: will, tomek. · View Herald TranscriptNov 9 2023, 8:19 AM

rohan edited the summary of this revision. (Show Details)Nov 9 2023, 8:21 AM

rohan added a child revision: D9805: [keyserver] Update changeRoleThreadQuery to use the Voiced role for announcement channels.Nov 9 2023, 8:33 AM

Harbormaster completed remote builds in B23965: Diff 33017.Nov 9 2023, 8:39 AM

rohan requested review of this revision.Nov 9 2023, 8:39 AM

This change makes sense, but we'll need to make sure we handle it in updateRoles, modifyRole, createInitialRolesForNewThread, etc. Assume you'll put those diffs up later and land them together with this one.

This revision is now accepted and ready to land.Nov 9 2023, 12:32 PM

rohan added a child revision: D9825: [keyserver] Migration to add Voiced role to announcement subchannels.Nov 10 2023, 9:54 AM

rohan removed a child revision: D9805: [keyserver] Update changeRoleThreadQuery to use the Voiced role for announcement channels.Nov 10 2023, 9:54 AM

rohan added a child revision: D9827: [keyserver/lib/native] Introduce VOICED_IN_ANNOUNCEMENT_CHANNELS thread permission.Nov 10 2023, 11:26 AM

rohan removed a child revision: D9827: [keyserver/lib/native] Introduce VOICED_IN_ANNOUNCEMENT_CHANNELS thread permission.Nov 10 2023, 11:30 AM

rohan edited the summary of this revision. (Show Details)Nov 17 2023, 7:09 AM

rohan added a parent revision: D9897: [lib] Introduce getUniversalCommunityRootPermissionsBlob.

rohan removed a parent revision: D9514: [lib/web/native] Show voiced_in_announcement_channels user-surfaced permission for all community types.

rohan edited the summary of this revision. (Show Details)

rohan added a parent revision: D9901: [lib] Rename getRolePermissionBlobsForCommunity to getRolePermissionBlobsForCommunityRoot.

rohan removed a parent revision: D9897: [lib] Introduce getUniversalCommunityRootPermissionsBlob.

Rebase