Page MenuHomePhabricator

[lib] Include Voiced permission blob for announcement channels
AbandonedPublic

Authored by rohan on Nov 9 2023, 8:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 9, 11:23 PM
Unknown Object (File)
Tue, Jul 9, 11:23 PM
Unknown Object (File)
Tue, Jul 9, 11:23 PM
Unknown Object (File)
Tue, Jul 9, 11:16 PM
Unknown Object (File)
Sun, Jul 7, 6:51 PM
Unknown Object (File)
Sun, Jul 7, 4:42 PM
Unknown Object (File)
Thu, Jul 4, 10:06 PM
Unknown Object (File)
Tue, Jul 2, 3:15 AM
Subscribers

Details

Reviewers
atul
ginsu
ashoat
Summary

For both COMMUNITY_OPEN_ANNOUNCEMENT_SUBTHREAD and COMMUNITY_SECRET_ANNOUNCEMENT_SUBTHREAD, we should include a Voiced permission blob. This should just be a union between the existing thread permissions blob and the voiced permissions blob. This is in an effort to correctly have the 'Voiced in announcement channels' user-surfaced permission allow users to speak in announcement channels.

Will add @ashoat as a reviewer for some diffs here since this is a solution we discussed in our 1:1

Addresses ENG-5634

Depends on D9901

Test Plan

Confirmed that subchannel creation still worked fine, and checked MariaDB to see for COMMUNITY_OPEN_ANNOUNCEMENT_SUBTHREAD and COMMUNITY_SECRET_ANNOUNCEMENT_SUBTHREAD, the Voiced role was also created.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

rohan requested review of this revision.Nov 9 2023, 8:39 AM

This change makes sense, but we'll need to make sure we handle it in updateRoles, modifyRole, createInitialRolesForNewThread, etc. Assume you'll put those diffs up later and land them together with this one.

This revision is now accepted and ready to land.Nov 9 2023, 12:32 PM

Abandoning this for now since we're reconsidering the Voiced approach