Page MenuHomePhabricator
Differential D9969

[native] Compute backup key for u8 slice
ClosedPublic
Actions

Authored by michal on Nov 24 2023, 8:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 22, 9:10 AM
Unknown Object (File)
Fri, Apr 18, 10:37 AM
Unknown Object (File)
Fri, Apr 18, 4:52 AM
Unknown Object (File)
Fri, Apr 18, 1:31 AM
Unknown Object (File)
Thu, Apr 17, 12:14 PM
Unknown Object (File)
Wed, Apr 9, 6:59 AM
Unknown Object (File)
Mon, Apr 7, 11:26 AM
Unknown Object (File)
Feb 27 2025, 4:19 PM
View All 67 Files
Subscribers
ashoat
tomek

Details

Reviewers
marcin
kamil
Commits
rCOMMe76d33b8a73b: [native] Compute backup key for u8 slice
Summary

ENG-5344

The current backup key generation function using argon2 library expects &str, as the data is passed from javascript. This diffs adds an additional variant that uses u8 slices as Rust code operates on bytes. Additionally I added std feature to argon2 in this diff so it's errors implement std::error::Error. This means we can use ? operator with Box<dyn Error> in later diffs.

Test Plan

Run the provided tests.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
native_rust_library/
6 lines
src/
23 lines
8 lines

Diff 33593

View Options

native/native_rust_library/Cargo.toml

[package] [package]
name = "backup" name = "backup"
version = "0.1.0" version = "0.1.0"
description = "Backup service" description = "Backup service"
homepage = "https://comm.app" homepage = "https://comm.app"
license = "BSD-3-Clause" license = "BSD-3-Clause"
edition = "2021" edition = "2021"
[dependencies] [dependencies]
anyhow = "1.0" anyhow = "1.0"
async-stream = "0.3" async-stream = "0.3"
aws-config = "0.55" aws-config = "0.55"
aws-sdk-dynamodb = "0.27" aws-sdk-dynamodb = "0.27"
aws-types = "0.55" aws-types = "0.55"
chrono = "0.4" chrono = "0.4"
clap = { version = "4.0", features = ["derive", "env"] } clap = { version = "4.0", features = ["derive", "env"] }
comm-services-lib = { path = "../comm-services-lib" } comm-services-lib = { path = "../comm-services-lib", features = ["http"] }
once_cell = "1.17" once_cell = "1.17"
rand = "0.8.5" rand = "0.8.5"
tokio = { version = "1.24", features = ["rt-multi-thread", "macros"] } tokio = { version = "1.24", features = ["rt-multi-thread", "macros"] }
tokio-stream = "0.1" tokio-stream = "0.1"
tracing = "0.1" tracing = "0.1"
tracing-futures = { version = "0.2", features = ["futures-03"] } tracing-futures = { version = "0.2", features = ["futures-03"] }
tracing-subscriber = { version = "0.3", features = ["env-filter"] } tracing-subscriber = { version = "0.3", features = ["env-filter"] }
uuid = { version = "1.2", features = ["v4"] } uuid = { version = "1.2", features = ["v4"] }
actix-web = "4.3"
tracing-actix-web = "0.7.3"
[build-dependencies] [build-dependencies]
tonic-build = "0.8" tonic-build = "0.8"
View Options

native/native_rust_library/src/argon2_tools.rs

[package] [package]
name = "backup" name = "backup"
version = "0.1.0" version = "0.1.0"
description = "Backup service" description = "Backup service"
homepage = "https://comm.app" homepage = "https://comm.app"
license = "BSD-3-Clause" license = "BSD-3-Clause"
edition = "2021" edition = "2021"
[dependencies] [dependencies]
anyhow = "1.0" anyhow = "1.0"
async-stream = "0.3" async-stream = "0.3"
aws-config = "0.55" aws-config = "0.55"
aws-sdk-dynamodb = "0.27" aws-sdk-dynamodb = "0.27"
aws-types = "0.55" aws-types = "0.55"
chrono = "0.4" chrono = "0.4"
clap = { version = "4.0", features = ["derive", "env"] } clap = { version = "4.0", features = ["derive", "env"] }
comm-services-lib = { path = "../comm-services-lib" } comm-services-lib = { path = "../comm-services-lib", features = ["http"] }
once_cell = "1.17" once_cell = "1.17"
rand = "0.8.5" rand = "0.8.5"
tokio = { version = "1.24", features = ["rt-multi-thread", "macros"] } tokio = { version = "1.24", features = ["rt-multi-thread", "macros"] }
tokio-stream = "0.1" tokio-stream = "0.1"
tracing = "0.1" tracing = "0.1"
tracing-futures = { version = "0.2", features = ["futures-03"] } tracing-futures = { version = "0.2", features = ["futures-03"] }
tracing-subscriber = { version = "0.3", features = ["env-filter"] } tracing-subscriber = { version = "0.3", features = ["env-filter"] }
uuid = { version = "1.2", features = ["v4"] } uuid = { version = "1.2", features = ["v4"] }
actix-web = "4.3"
tracing-actix-web = "0.7.3"
[build-dependencies] [build-dependencies]
tonic-build = "0.8" tonic-build = "0.8"
View Options

native/native_rust_library/src/lib.rs

[package] [package]
name = "backup" name = "backup"
version = "0.1.0" version = "0.1.0"
description = "Backup service" description = "Backup service"
homepage = "https://comm.app" homepage = "https://comm.app"
license = "BSD-3-Clause" license = "BSD-3-Clause"
edition = "2021" edition = "2021"
[dependencies] [dependencies]
anyhow = "1.0" anyhow = "1.0"
async-stream = "0.3" async-stream = "0.3"
aws-config = "0.55" aws-config = "0.55"
aws-sdk-dynamodb = "0.27" aws-sdk-dynamodb = "0.27"
aws-types = "0.55" aws-types = "0.55"
chrono = "0.4" chrono = "0.4"
clap = { version = "4.0", features = ["derive", "env"] } clap = { version = "4.0", features = ["derive", "env"] }
comm-services-lib = { path = "../comm-services-lib" } comm-services-lib = { path = "../comm-services-lib", features = ["http"] }
once_cell = "1.17" once_cell = "1.17"
rand = "0.8.5" rand = "0.8.5"
tokio = { version = "1.24", features = ["rt-multi-thread", "macros"] } tokio = { version = "1.24", features = ["rt-multi-thread", "macros"] }
tokio-stream = "0.1" tokio-stream = "0.1"
tracing = "0.1" tracing = "0.1"
tracing-futures = { version = "0.2", features = ["futures-03"] } tracing-futures = { version = "0.2", features = ["futures-03"] }
tracing-subscriber = { version = "0.3", features = ["env-filter"] } tracing-subscriber = { version = "0.3", features = ["env-filter"] }
uuid = { version = "1.2", features = ["v4"] } uuid = { version = "1.2", features = ["v4"] }
actix-web = "4.3"
tracing-actix-web = "0.7.3"
[build-dependencies] [build-dependencies]
tonic-build = "0.8" tonic-build = "0.8"