Page MenuHomePhabricator

[native] Add native backup functions
ClosedPublic

Authored by michal on Nov 24 2023, 8:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 27, 9:44 AM
Unknown Object (File)
Fri, Dec 27, 9:44 AM
Unknown Object (File)
Fri, Dec 27, 9:43 AM
Unknown Object (File)
Fri, Dec 27, 9:33 AM
Unknown Object (File)
Sat, Dec 21, 10:07 PM
Unknown Object (File)
Wed, Dec 4, 10:02 PM
Unknown Object (File)
Sun, Dec 1, 7:44 PM
Unknown Object (File)
Nov 3 2024, 12:02 PM
Subscribers

Details

Summary

Boilerplate for backup functions called from js.

Test Plan

Check that the app compiles. Run the functions from js.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

native/schema/CommCoreModuleSchema.js
111–117 ↗(On Diff #33596)

Most of these arguments are for testing purposes.

After we implement networking to the backup service in rust we will be able to return Promise<void> in createNewBackup and delete backupID, encryptedUserKeys, encryptedUserData in restoreBackup. These are required for now, because networking goes through JS.

After we implement SQLite integration we will be able to remove userData from createNewBackup as it will be taken from db in native code.

I am under impression that this differential should be merged with its child differential, but I will leave it up to you.

This revision is now accepted and ready to land.Nov 27 2023, 9:05 AM