Page MenuHomePhabricator
Differential D10067

[native] Backup testing button
ClosedPublic
Actions

Authored by michal on Nov 28 2023, 7:00 AM.
Tags
None
Referenced Files
F3505405: D10067.diff
Fri, Dec 20, 1:21 PM
Unknown Object (File)
Thu, Dec 19, 5:49 AM
Unknown Object (File)
Thu, Dec 19, 5:49 AM
Unknown Object (File)
Thu, Dec 19, 5:49 AM
Unknown Object (File)
Thu, Dec 19, 5:49 AM
Unknown Object (File)
Thu, Dec 19, 5:49 AM
Unknown Object (File)
Nov 3 2024, 11:51 AM
Unknown Object (File)
Nov 1 2024, 11:16 PM
View All 61 Files
Subscribers
ashoat
tomek

Details

Reviewers
marcin
kamil
Commits
rCOMM7a11d2e75b0a: [native] Backup testing button
Summary

ENG-5699

This is the final testing task for rust native encryption. This diff rewires the current backup testing logic to use the native encryption (the existing logic already handles uploading and downloading backups from the backup service, but previously it called encryption from JS).

Depends on D10055

Test Plan
  1. Enable backup encryption
  2. Test the restore procedure -> check that there are no errors
  3. Modify user store (e.g. relationship status) to trigger new backup upload
  4. Test the restore procedure again -> check that there are no errors

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

michal created this revision.Nov 28 2023, 7:00 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 28 2023, 7:00 AM
michal added inline comments.Nov 28 2023, 7:14 AM
native/backup/use-client-backup.js
28

Removed as a successful decryption of UserKeys is a requirement for a successful decryption of UserData, so we are still checking it. And now it's harder to check this in specific as it's done in rust.

Harbormaster completed remote builds in B24565: Diff 33940.Nov 28 2023, 7:46 AM
michal requested review of this revision.Nov 28 2023, 7:46 AM
kamil accepted this revision.Nov 30 2023, 2:32 AM

Would be nice to test it on both platforms and physical devices, in past this test helped me catch some issues

native/backup/use-client-backup.js
99

thanks for fixing this typo

This revision is now accepted and ready to land.Nov 30 2023, 2:32 AM
michal updated this revision to Diff 34101.Dec 1 2023, 4:21 AM

Rebase

Harbormaster completed remote builds in B24684: Diff 34101.Dec 1 2023, 4:43 AM
Closed by commit rCOMM7a11d2e75b0a: [native] Backup testing button (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyDec 1 2023, 6:20 AM
This revision was automatically updated to reflect the committed changes.
Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM7a11d2e75b0a: [native] Backup testing button.

Revision Contents
Changeset List

PathSize
lib/
types/
4 lines
native/
backup/
24 lines
2 lines
8 lines
82 lines

Diff 33940

View Options

lib/types/backup-types.js

Loading...
View Options

native/backup/api.js

Loading...
View Options

native/backup/constants.js

Loading...
View Options

native/backup/conversion-utils.js

Loading...
View Options

native/backup/encryption.js

Loading...
View Options

native/backup/use-client-backup.js

Loading...